Skip to content

Commit 8108f4d

Browse files
committed
address comments
1 parent 0fd43f8 commit 8108f4d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_batch_unsampled_span_processor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class BatchUnsampledSpanProcessor(BaseBatchSpanProcessor):
1818
# pylint: disable=no-self-use
1919
def on_start(self, span: Span, parent_context: Optional[Context] = None) -> None:
2020
if not span.context.trace_flags.sampled:
21-
span.set_attribute(AWS_TRACE_FLAG_UNSAMPLED, "True")
21+
span.set_attribute(AWS_TRACE_FLAG_UNSAMPLED, True)
2222

2323
def on_end(self, span: ReadableSpan) -> None:
2424
if span.context.trace_flags.sampled:

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ def _init_tracing(
155155
span_exporter = _customize_exporter(span_exporter, resource)
156156
trace_provider.add_span_processor(BatchSpanProcessor(span_exporter))
157157

158-
_export_unsampled_span_for_lambda(trace_provider, resource)
159158
_customize_span_processors(trace_provider, resource)
160159

161160
set_tracer_provider(trace_provider)
@@ -276,6 +275,8 @@ def _customize_span_processors(provider: TracerProvider, resource: Resource) ->
276275
if not _is_application_signals_enabled():
277276
return
278277

278+
_export_unsampled_span_for_lambda(provider, resource)
279+
279280
# Construct and set local and remote attributes span processor
280281
provider.add_span_processor(AttributePropagatingSpanProcessorBuilder().build())
281282

0 commit comments

Comments
 (0)