Skip to content

Commit 865f930

Browse files
authored
Fix: Deprecated GitHub Artifacts (#326)
*Issue #, if available:* Github workflows are failing due to: ``` Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ ``` A downstream effect of upgrading to `v4` is this version no longer allows uploading artifacts with same name. See: https://github.com/aws-observability/aws-otel-java-instrumentation/pull/1014/files *Description of changes:* We apply the same fix in the above PR By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent 9869674 commit 865f930

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/main-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ jobs:
8787
aws s3 cp dist/${{ steps.staging_wheel_output.outputs.STAGING_WHEEL}} s3://${{ env.STAGING_S3_BUCKET }}
8888
8989
- name: Upload Wheel to GitHub Actions
90-
uses: actions/upload-artifact@v3
90+
uses: actions/upload-artifact@v4
9191
with:
9292
name: ${{ steps.staging_wheel_output.outputs.STAGING_WHEEL}}
9393
path: dist/${{ steps.staging_wheel_output.outputs.STAGING_WHEEL}}

.github/workflows/release-lambda.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ jobs:
130130
if: ${{ success() }}
131131
uses: actions/upload-artifact@v4
132132
with:
133-
name: ${{ env.LAYER_NAME }}
133+
name: ${{ env.LAYER_NAME }}-${{ matrix.aws_region }}
134134
path: ${{ env.LAYER_NAME }}/${{ matrix.aws_region }}
135135
- name: clean s3
136136
if: always()
@@ -146,8 +146,9 @@ jobs:
146146
- name: download layerARNs
147147
uses: actions/download-artifact@v4
148148
with:
149-
name: ${{ env.LAYER_NAME }}
149+
name: ${{ env.LAYER_NAME }}-*
150150
path: ${{ env.LAYER_NAME }}
151+
merge-multiple: true
151152
- name: show layerARNs
152153
run: |
153154
for file in ${{ env.LAYER_NAME }}/*

0 commit comments

Comments
 (0)