Skip to content

Commit a6f4a0b

Browse files
committed
linting fix
1 parent efafc4b commit a6f4a0b

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/exporter/otlp/aws/common/aws_auth_session.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
2+
# SPDX-License-Identifier: Apache-2.0
3+
14
import logging
25

36
import requests
@@ -36,7 +39,7 @@ def __init__(self, aws_region, service):
3639

3740
super().__init__()
3841

39-
def request(self, method, url, data=None, headers=None, *args, **kwargs):
42+
def request(self, method, url, *args, data=None, headers=None, **kwargs):
4043
if self._has_required_dependencies:
4144

4245
credentials = self._boto_session.get_credentials()
@@ -62,7 +65,4 @@ def request(self, method, url, data=None, headers=None, *args, **kwargs):
6265
except Exception as signing_error: # pylint: disable=broad-except
6366
_logger.error("Failed to sign request: %s", signing_error)
6467

65-
return super().request(method, url, data=data, headers=headers, *args, **kwargs)
66-
67-
def close(self):
68-
super().close()
68+
return super().request(method=method, url=url, *args, data=data, headers=headers, **kwargs)

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_otlp_aws_exporter.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def test_sigv4_exporter_init_default(self):
3636
]
3737

3838
for tc in test_cases:
39-
self.validate_exporter_extends_http_exporter(exporter=tc[0], endpoint=tc[1], type=tc[2])
39+
self.validate_exporter_extends_http_exporter(exporter=tc[0], endpoint=tc[1], exporter_type=tc[2])
4040

4141
@patch("pkg_resources.get_distribution", side_effect=ImportError("test error"))
4242
@patch.dict("sys.modules", {"botocore": None}, clear=False)
@@ -81,8 +81,8 @@ def test_aws_auth_session(self, _, __):
8181
self.assertIn(X_AMZ_DATE_HEADER, actual_headers)
8282
self.assertIn(X_AMZ_SECURITY_TOKEN_HEADER, actual_headers)
8383

84-
def validate_exporter_extends_http_exporter(self, exporter, endpoint, type):
85-
self.assertIsInstance(exporter, type)
84+
def validate_exporter_extends_http_exporter(self, exporter, endpoint, exporter_type):
85+
self.assertIsInstance(exporter, exporter_type)
8686
self.assertIsInstance(exporter._session, AwsAuthSession)
8787
self.assertEqual(exporter._endpoint, endpoint)
8888
self.assertEqual(exporter._certificate_file, True)

0 commit comments

Comments
 (0)