Skip to content

Commit a9df9a8

Browse files
authored
[AppSignal E2E Testing] Validate E2E Tests Are Accounted For (#444)
*Issue #, if available:* *Description of changes:* Add new validation workflow: - This validation is to ensure that all ApplicationSignals e2e test workflows relevant to this repo are actually being used in this repo. - See: https://github.com/aws-observability/aws-application-signals-test-framework/blob/main/.github/workflows/validate-e2e-tests-are-accounted-for.yml *Testing:* <img width="3138" height="1632" alt="image" src="https://github.com/user-attachments/assets/74251329-857c-47c4-880c-60423d536b2d" /> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent 2388f5f commit a9df9a8

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

.github/workflows/application-signals-e2e-test.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,3 +247,19 @@ jobs:
247247
with:
248248
caller-workflow-name: 'main-build'
249249
staging-wheel-name: ${{ inputs.staging-wheel-name }}
250+
251+
# This validation is to ensure that all test workflows relevant to this repo are actually
252+
# being used in this repo, which is referring to all the other jobs in this file.
253+
#
254+
# If this starts failing, then it most likely means that new e2e test workflow was
255+
# added to `aws-observability/aws-application-signals-test-framework`, but was not
256+
# added to this file. It could also mean that a test in this file has been removed.
257+
#
258+
# If a particular test file is intended to not be tested in this repo and should not
259+
# be failing this particular validation, then choose one of the following options:
260+
# - Add the test file to the exclusions input (CSV format) to the workflow
261+
# (see: https://github.com/aws-observability/aws-application-signals-test-framework/blob/main/.github/workflows/validate-e2e-tests-are-accounted-for.yml#L1)
262+
# - Update the `validate-e2e-tests-are-accounted-for` job to change which "workflow files are expected to be used by this repo"
263+
# (see: https://github.com/aws-observability/aws-application-signals-test-framework/blob/main/.github/workflows/validate-e2e-tests-are-accounted-for.yml)
264+
validate-all-tests-are-accounted-for:
265+
uses: aws-observability/aws-application-signals-test-framework/.github/workflows/validate-e2e-tests-are-accounted-for.yml@main

0 commit comments

Comments
 (0)