cleanup

Author: liustve

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py

@@ -39,12 +39,10 @@ def __init__(
             max_queue_size=max_queue_size,
         )
 
-    # Code based off of:
     # https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py#L143
     def _export(self, batch_strategy: BatchLogExportStrategy) -> None:
         """
-        Overrides the batching behavior of upstream's export method. Preserves existing batching behavior but
-        will intermediarly export small log batches if the size of the data in the batch is at or
+        Preserves existing batching behavior but will intermediarly export small log batches if the size of the data in the batch is at or
         above AWS CloudWatch's maximum request size limit of 1 MB.
 
         - Data size of exported batches will ALWAYS be <= 1 MB except for the case below:
@@ -91,7 +89,8 @@ def _export(self, batch_strategy: BatchLogExportStrategy) -> None:
                     _logger.exception("Exception while exporting logs.")
                 detach(token)
 
-    def _get_size_of_log(self, log_data: LogData) -> int:
+    @staticmethod
+    def _get_size_of_log(log_data: LogData) -> int:
         """
         Estimates the size of a given LogData based on the size of the body + a buffer
         amount representing a rough guess of other data present in the log.
@@ -100,11 +99,12 @@ def _get_size_of_log(self, log_data: LogData) -> int:
         body = log_data.log_record.body
 
         if body:
-            size += self._get_size_of_any_value(body)
+            size += AwsBatchLogRecordProcessor._get_size_of_any_value(body)
 
         return size
 
-    def _get_size_of_any_value(self, val: AnyValue) -> int:
+    @staticmethod
+    def _get_size_of_any_value(val: AnyValue) -> int:
         """
         Recursively calculates the size of an AnyValue type in bytes.
         """
@@ -114,19 +114,17 @@ def _get_size_of_any_value(self, val: AnyValue) -> int:
             return len(val)
 
         if isinstance(val, bool):
-            if val:
-                return 4  # len(True) = 4
-            return 5  # len(False) = 5
-
+            return 4 if val else 5
+        
         if isinstance(val, int) or isinstance(val, float):
             return len(str(val))
 
         if isinstance(val, Sequence):
             for content in val:
-                size += self._get_size_of_any_value(content)
+                size += AwsBatchLogRecordProcessor._get_size_of_any_value(content)
 
         if isinstance(val, Mapping):
             for _, content in val.items():
-                size += self._get_size_of_any_value(content)
+                size += AwsBatchLogRecordProcessor._get_size_of_any_value(content)
 
         return size