prefix AWS.SDK to the RemoteService for AWS SDK spans (#83)

Similar to what we do in adot java:
aws-observability/aws-otel-java-instrumentation#756

If the span is an AWS SDK (boto) span, then we will prefix the
RemoteService name with `AWS.SDK.` for consistency across the metrics
generated from different ADOT SDKs

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

Author: srprash

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py

@@ -27,6 +27,7 @@
     extract_api_path_value,
     get_egress_operation,
     get_ingress_operation,
+    is_aws_sdk_span,
     is_key_present,
     is_local_root,
     should_generate_dependency_metric_attributes,
@@ -268,10 +269,9 @@ def _get_db_statement_remote_operation(span: ReadableSpan, statement_key: str) -
 
 
 def _normalize_service_name(span: ReadableSpan, service_name: str) -> str:
-    """
-    TODO: Determine if problems in Java instrumentation are relevant here. Do we need normalization? If so, probably we
-     are looking for boto, not aws-sdk
-    """
+    if is_aws_sdk_span(span):
+        return "AWS.SDK." + service_name
+
     return service_name
 
 

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_aws_metric_attribute_generator.py

@@ -674,6 +674,25 @@ def test_both_metric_when_local_root_consumer_process(self):
         self.assertIsNotNone(service_attributes)
         self.assertIsNotNone(dependency_attributes)
 
+    def test_normalize_service_name_non_aws_sdk_span(self):
+        service_name: str = "non aws service"
+        self._mock_attribute([SpanAttributes.RPC_SERVICE], [service_name])
+        self.span_mock.kind = SpanKind.CLIENT
+
+        actual_attributes: Attributes = _GENERATOR.generate_metric_attributes_dict_from_span(
+            self.span_mock, self.resource
+        ).get(DEPENDENCY_METRIC)
+        self.assertEqual(actual_attributes.get(AWS_REMOTE_SERVICE), service_name)
+
+    def test_normalize_service_name_aws_sdk_span(self):
+        self._mock_attribute([SpanAttributes.RPC_SYSTEM, SpanAttributes.RPC_SERVICE], ["aws-api", "EC2"])
+        self.span_mock.kind = SpanKind.CLIENT
+
+        actual_attributes: Attributes = _GENERATOR.generate_metric_attributes_dict_from_span(
+            self.span_mock, self.resource
+        ).get(DEPENDENCY_METRIC)
+        self.assertEqual(actual_attributes.get(AWS_REMOTE_SERVICE), "AWS.SDK.EC2")
+
     def _update_resource_with_service_name(self) -> None:
         self.resource: Resource = Resource(attributes={SERVICE_NAME: _SERVICE_NAME_VALUE})