Skip to content

Commit d839892

Browse files
committed
loosen verification step for daemon receiving traces
1 parent 6017713 commit d839892

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

.github/workflows/release-udp-exporter.yml

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,12 @@ jobs:
2626
working-directory: exporters/aws-otel-otlp-udp-exporter
2727
run: hatch build
2828

29+
- name: configure AWS credentials
30+
uses: aws-actions/configure-aws-credentials@v4
31+
with:
32+
role-to-assume: ${{ secrets.AWS_ROLE_ARN_TESTING }}
33+
aws-region: us-west-2
34+
2935
- name: Setup X-Ray daemon
3036
run: |
3137
# Download X-Ray daemon
@@ -39,15 +45,7 @@ jobs:
3945
"Logging": {
4046
"LogLevel": "debug"
4147
},
42-
"LocalMode": true
4348
}' > xray-daemon-config.json
44-
45-
# Create dummy AWS credentials (the daemon requires credentials even if local)
46-
mkdir -p ~/.aws
47-
echo "[default]
48-
aws_access_key_id=AKIAIOSFODNN7EXAMPLE
49-
aws_secret_access_key=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY
50-
region=us-west-2" > ~/.aws/credentials
5149
5250
# Make sure xray is executable
5351
chmod +x ./xray
@@ -172,16 +170,19 @@ jobs:
172170
working-directory: validation_app
173171
run: python test_exporter.py
174172

175-
- name: Verify X-Ray daemon recieved traces
173+
- name: Verify X-Ray daemon received traces
176174
run: |
177175
echo "X-Ray daemon logs:"
178176
cat daemon-logs/xray-daemon.log
179177
180-
# Check if the daemon received segments
181-
if grep -q "Received segment" daemon-logs/xray-daemon.log; then
182-
echo "✅ X-Ray daemon successfully received trace segments"
178+
# Check if the daemon received and processed some data
179+
if grep -q "sending.*batch" daemon-logs/xray-daemon.log; then
180+
echo "✅ X-Ray daemon processed trace data (AWS upload errors are expected)"
181+
exit 0
182+
elif grep -q "processor:.*segment" daemon-logs/xray-daemon.log; then
183+
echo "✅ X-Ray daemon processed segment data (AWS upload errors are expected)"
183184
exit 0
184185
else
185-
echo "❌ No trace segments received by X-Ray daemon"
186+
echo "❌ No evidence of traces being received by X-Ray daemon"
186187
exit 1
187188
fi

0 commit comments

Comments
 (0)