Skip to content

Commit d8ce58a

Browse files
committed
Lint fix + Unit test fix
1 parent b49118e commit d8ce58a

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_distro.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919
OTEL_TRACES_SAMPLER,
2020
)
2121
from amazon.opentelemetry.distro.patches._instrumentation_patch import apply_instrumentation_patches
22+
from opentelemetry import propagate
2223
from opentelemetry.distro import OpenTelemetryDistro
2324
from opentelemetry.environment_variables import OTEL_PROPAGATORS, OTEL_PYTHON_ID_GENERATOR
2425
from opentelemetry.sdk.environment_variables import (
2526
OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION,
2627
OTEL_EXPORTER_OTLP_PROTOCOL,
2728
)
28-
from opentelemetry import propagate
2929

3030
_logger: Logger = getLogger(__name__)
3131

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_aws_opentelementry_configurator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1262,7 +1262,7 @@ def validate_distro_environ():
12621262
tc.assertEqual(
12631263
"base2_exponential_bucket_histogram", os.environ.get("OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION")
12641264
)
1265-
tc.assertEqual("xray,tracecontext,b3,b3multi", os.environ.get("OTEL_PROPAGATORS"))
1265+
tc.assertEqual("tracecontext,baggage,xray", os.environ.get("OTEL_PROPAGATORS"))
12661266
tc.assertEqual("xray", os.environ.get("OTEL_PYTHON_ID_GENERATOR"))
12671267

12681268
# Not set

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_aws_opentelemetry_distro.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
22
# SPDX-License-Identifier: Apache-2.0
3-
import os
43
import importlib
4+
import os
55
import sys
66
from importlib.metadata import PackageNotFoundError, version
77
from unittest import TestCase
88
from unittest.mock import patch
99

1010
from amazon.opentelemetry.distro.aws_opentelemetry_distro import AwsOpenTelemetryDistro
11+
from opentelemetry import propagate
1112
from opentelemetry.propagators.composite import CompositePropagator
1213

1314

@@ -102,7 +103,7 @@ def test_configure_without_patches(self, mock_super_configure, mock_apply_patche
102103
@patch("amazon.opentelemetry.distro.aws_opentelemetry_distro.apply_instrumentation_patches")
103104
@patch("amazon.opentelemetry.distro.aws_opentelemetry_distro.OpenTelemetryDistro._configure")
104105
def test_configure_with_agent_observability_enabled(
105-
self, mock_super_configure, mock_apply_patches, mock_is_agent_observability, mock_get_aws_region
106+
self, mock_super_configure, mock_apply_patches, mock_is_agent_observability, mock_get_aws_region
106107
):
107108
"""Test that _configure sets agent observability defaults when enabled"""
108109
mock_is_agent_observability.return_value = True
@@ -240,7 +241,6 @@ def test_user_defined_propagators(self):
240241

241242
# Force the reload of the propagate module otherwise the above environment
242243
# variable doesn't taker effect.
243-
from opentelemetry import propagate
244244
importlib.reload(propagate)
245245

246246
distro = AwsOpenTelemetryDistro()
@@ -253,7 +253,7 @@ def test_user_defined_propagators(self):
253253
individual_propagators = propagators._propagators
254254
self.assertEqual(1, len(individual_propagators))
255255
actual_propagators = []
256-
for i, prop in enumerate(individual_propagators):
256+
for prop in individual_propagators:
257257
actual_propagators.append(type(prop).__name__)
258258
self.assertEqual(expected_propagators, actual_propagators)
259259

@@ -262,7 +262,6 @@ def test_otel_propagators_added_when_not_user_defined(self):
262262
distro._configure()
263263

264264
# Verify that the propagators are set correctly by ADOT
265-
from opentelemetry import propagate
266265
propagators = propagate.get_global_textmap()
267266

268267
self.assertTrue(isinstance(propagators, CompositePropagator))
@@ -271,6 +270,6 @@ def test_otel_propagators_added_when_not_user_defined(self):
271270
individual_propagators = propagators._propagators
272271
self.assertEqual(3, len(individual_propagators))
273272
actual_propagators = []
274-
for i, prop in enumerate(individual_propagators):
273+
for prop in individual_propagators:
275274
actual_propagators.append(type(prop).__name__)
276275
self.assertEqual(expected_propagators, actual_propagators)

0 commit comments

Comments
 (0)