Skip to content

Commit e2a6c4c

Browse files
committed
update comments
1 parent d9d2dfe commit e2a6c4c

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

.github/workflows/nightly-build.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ jobs:
7070
echo "Dependencies were updated"
7171
echo "has_changes=true" >> $GITHUB_OUTPUT
7272
73-
# Create PR immediately
73+
# Create PR
7474
git add aws-opentelemetry-distro/pyproject.toml
7575
git commit -m "chore: update OpenTelemetry dependencies to ${{ steps.get_versions.outputs.otel_python_version }}/${{ steps.get_versions.outputs.otel_contrib_version }}"
7676
git push origin "$BRANCH_NAME"
@@ -81,11 +81,7 @@ jobs:
8181
8282
**Updated versions:**
8383
- OpenTelemetry Python: ${{ steps.get_versions.outputs.otel_python_version }}
84-
- OpenTelemetry Contrib: ${{ steps.get_versions.outputs.otel_contrib_version }}
85-
86-
**Status:** Tests are running in the nightly workflow. Check the workflow results for compatibility status.
87-
88-
This PR will trigger additional validation via pr-build workflow including multi-version testing and linting." \
84+
- OpenTelemetry Contrib: ${{ steps.get_versions.outputs.otel_contrib_version }}" \
8985
--base main \
9086
--head "$BRANCH_NAME"
9187
fi

scripts/get_upstream_versions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ def get_latest_otel_versions():
2121
print(f"Could not parse release title: {release_title}")
2222
sys.exit(1)
2323

24-
otel_python_version = match.group(1) # e.g., "1.37.0"
25-
otel_contrib_version = match.group(2) # e.g., "0.58b0"
24+
otel_python_version = match.group(1)
25+
otel_contrib_version = match.group(2)
2626

2727
return otel_python_version, otel_contrib_version
2828

scripts/update_dependencies.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import re
66
import requests
77

8-
# Dependencies that use the first version number (opentelemetry-python)
8+
# Dependencies that use the opentelemetry-python version number
99
PYTHON_CORE_DEPS = [
1010
'opentelemetry-api',
1111
'opentelemetry-sdk',
@@ -17,7 +17,7 @@
1717
'opentelemetry-exporter-otlp-proto-common',
1818
]
1919

20-
# Dependencies that use the second version number (opentelemetry-python-contrib)
20+
# Dependencies that use the opentelemetry-python-contrib version number
2121
CONTRIB_DEPS = [
2222
'opentelemetry-distro',
2323
'opentelemetry-processor-baggage',
@@ -68,7 +68,7 @@
6868
'opentelemetry-instrumentation-cassandra',
6969
]
7070

71-
# AWS-specific packages with independent versioning
71+
packages with independent versioning
7272
AWS_DEPS = [
7373
'opentelemetry-sdk-extension-aws',
7474
'opentelemetry-propagator-aws-xray',
@@ -101,23 +101,23 @@ def main():
101101

102102
updated = False
103103

104-
# Update Python core dependencies
104+
# Update opentelemetry-python dependencies
105105
for dep in PYTHON_CORE_DEPS:
106106
pattern = rf'"{re.escape(dep)} == [^"]*"'
107107
replacement = f'"{dep} == {otel_python_version}"'
108108
if re.search(pattern, content):
109109
content = re.sub(pattern, replacement, content)
110110
updated = True
111111

112-
# Update contrib dependencies
112+
# Update opentelemetry-python-contrib dependencies
113113
for dep in CONTRIB_DEPS:
114114
pattern = rf'"{re.escape(dep)} == [^"]*"'
115115
replacement = f'"{dep} == {otel_contrib_version}"'
116116
if re.search(pattern, content):
117117
content = re.sub(pattern, replacement, content)
118118
updated = True
119119

120-
# Update AWS dependencies with their latest versions
120+
# Update dependencies with independent versioning
121121
for dep in AWS_DEPS:
122122
latest_version = get_latest_version(dep)
123123
if latest_version:

0 commit comments

Comments
 (0)