Skip to content

Commit ec98293

Browse files
committed
fix unit test coverage
1 parent f91d294 commit ec98293

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_aws_batch_unsampled_span_processor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class TestBatchUnsampledSpanProcessor(TestCase):
1010

1111
def setUp(self):
1212
self.mock_exporter = MagicMock()
13-
self.processor = BatchUnsampledSpanProcessor(self.mock_exporter)
13+
self.processor = BatchUnsampledSpanProcessor(self.mock_exporter, max_queue_size=1, max_export_batch_size=1)
1414

1515
@patch("opentelemetry.sdk.trace.Span")
1616
def test_on_end_sampled(self, mock_span_class):

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_otlp_udp_exporter.py

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
OTLPUdpMetricExporter,
1313
OTLPUdpSpanExporter,
1414
UdpExporter,
15+
FORMAT_OTEL_SAMPLED_TRACES_BINARY_PREFIX,
1516
FORMAT_OTEL_UNSAMPLED_TRACES_BINARY_PREFIX,
1617
)
1718
from opentelemetry.sdk.metrics._internal.export import MetricExportResult
@@ -99,7 +100,7 @@ class TestOTLPUdpSpanExporter(unittest.TestCase):
99100

100101
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.encode_spans")
101102
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.UdpExporter")
102-
def test_export(self, mock_udp_exporter, mock_encode_spans):
103+
def test_export_unsampled_span(self, mock_udp_exporter, mock_encode_spans):
103104
mock_udp_exporter_instance = mock_udp_exporter.return_value
104105
mock_encoded_data = MagicMock()
105106
mock_encode_spans.return_value.SerializeToString.return_value = mock_encoded_data
@@ -110,6 +111,19 @@ def test_export(self, mock_udp_exporter, mock_encode_spans):
110111
)
111112
self.assertEqual(result, SpanExportResult.SUCCESS)
112113

114+
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.encode_spans")
115+
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.UdpExporter")
116+
def test_export_sampled_span(self, mock_udp_exporter, mock_encode_spans):
117+
mock_udp_exporter_instance = mock_udp_exporter.return_value
118+
mock_encoded_data = MagicMock()
119+
mock_encode_spans.return_value.SerializeToString.return_value = mock_encoded_data
120+
exporter = OTLPUdpSpanExporter()
121+
result = exporter.export(MagicMock())
122+
mock_udp_exporter_instance.send_data.assert_called_once_with(
123+
data=mock_encoded_data, signal_format_prefix=FORMAT_OTEL_SAMPLED_TRACES_BINARY_PREFIX
124+
)
125+
self.assertEqual(result, SpanExportResult.SUCCESS)
126+
113127
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.encode_spans")
114128
@patch("amazon.opentelemetry.distro.otlp_udp_exporter.UdpExporter")
115129
def test_export_with_exception(self, mock_udp_exporter, mock_encode_spans):

0 commit comments

Comments
 (0)