Skip to content

Commit f54609e

Browse files
committed
Working Version of Cleaned Up Code
1 parent 3f576c2 commit f54609e

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/mcpinstrumentor/mcpinstrumentor.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@
1010
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
1111
from opentelemetry.instrumentation.utils import unwrap
1212

13-
from .package import _instruments
13+
_instruments = ("mcp >= 1.6.0",)
1414

1515

16-
def setup_logger_two():
17-
logger = logging.getLogger("loggertwo")
16+
def setup_logger():
17+
logger = logging.getLogger("logger")
1818
logger.setLevel(logging.DEBUG)
19-
handler = logging.FileHandler("loggertwo.log", mode="w")
19+
handler = logging.FileHandler("logger.log", mode="w")
2020
handler.setLevel(logging.DEBUG)
2121
formatter = logging.Formatter("%(asctime)s - %(levelname)s - %(message)s")
2222
handler.setFormatter(formatter)
@@ -146,6 +146,9 @@ def _generate_mcp_attributes(self, span: trace.Span, request: ClientRequest, is_
146146
elif isinstance(request, types.CallToolRequest):
147147
operation = request.params.name
148148
span.set_attribute("mcp.call_tool", True)
149+
elif isinstance(request, types.InitializeRequest):
150+
operation = "Initialize"
151+
span.set_attribute("mcp.initialize", True)
149152
if is_client:
150153
self._add_client_attributes(span, operation, request)
151154
else:
@@ -191,13 +194,15 @@ def _get_mcp_operation(req: ClientRequest) -> str:
191194
span_name = "tools/list"
192195
elif isinstance(req, types.CallToolRequest):
193196
span_name = f"tools/{req.params.name}"
197+
elif isinstance(req, types.InitializeRequest):
198+
span_name = "tools/initialize"
194199
return span_name
195200

196201
@staticmethod
197202
def _add_client_attributes(span: trace.Span, operation: str, request: ClientRequest) -> None:
198203
import os # pylint: disable=import-outside-toplevel
199204

200-
service_name = os.environ.get("MCP_SERVICE_NAME", "Generic MCP Server")
205+
service_name = os.environ.get("MCP_INSTRUMENTATION_SERVER_NAME", "mcp server")
201206
span.set_attribute("aws.remote.service", service_name)
202207
span.set_attribute("aws.remote.operation", operation)
203208
if hasattr(request, "params") and request.params and hasattr(request.params, "name"):

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/mcpinstrumentor/package.py

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)