From c0794dd2f7d942fe073d1ac3ff4037bd5100d555 Mon Sep 17 00:00:00 2001 From: yiyuanh Date: Wed, 2 Oct 2024 16:02:49 -0700 Subject: [PATCH 1/2] fix: Change Lambda Resource CFN Primary Id to be Lambda Name --- .../opentelemetry/distro/_aws_metric_attribute_generator.py | 1 - 1 file changed, 1 deletion(-) diff --git a/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py b/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py index 40a4fd46b..b5486e997 100644 --- a/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py +++ b/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py @@ -460,7 +460,6 @@ def _set_remote_type_and_identifier(span: ReadableSpan, attributes: BoundedAttri elif is_key_present(span, AWS_LAMBDA_FUNCTION_NAME): remote_resource_type = _NORMALIZED_LAMBDA_SERVICE_NAME + "::Function" remote_resource_identifier = _escape_delimiters(span.attributes.get(AWS_LAMBDA_FUNCTION_NAME)) - cloudformation_primary_identifier = _escape_delimiters(span.attributes.get(AWS_LAMBDA_FUNCTION_ARN)) elif is_db_span(span): remote_resource_type = _DB_CONNECTION_STRING_TYPE remote_resource_identifier = _get_db_connection(span) From d485687b8cd29bcb4cb343af7675e4ce7c06baa4 Mon Sep 17 00:00:00 2001 From: yiyuanh Date: Wed, 2 Oct 2024 16:15:59 -0700 Subject: [PATCH 2/2] chore: Remove unused import --- .../opentelemetry/distro/_aws_metric_attribute_generator.py | 1 - 1 file changed, 1 deletion(-) diff --git a/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py b/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py index b5486e997..93d13ee9b 100644 --- a/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py +++ b/aws-opentelemetry-distro/src/amazon/opentelemetry/distro/_aws_metric_attribute_generator.py @@ -12,7 +12,6 @@ AWS_BEDROCK_KNOWLEDGE_BASE_ID, AWS_CLOUDFORMATION_PRIMARY_IDENTIFIER, AWS_KINESIS_STREAM_NAME, - AWS_LAMBDA_FUNCTION_ARN, AWS_LAMBDA_FUNCTION_NAME, AWS_LAMBDA_RESOURCEMAPPING_ID, AWS_LOCAL_OPERATION,