Fix regions and add clarity in Lambda Layer release workflow #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jj22ee
force-pushed
the
update-lambda-layer-release
branch
from
c5fadb1 to
614417e
Compare
wangzlei
approved these changes
Aug 14, 2025
jj22ee
added a commit
that referenced
this pull request
Aug 14, 2025
*Description of changes:* Cherry-pick #458 to `v0.11.x` release branch By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
jj22ee
added a commit
to aws-observability/aws-otel-js-instrumentation
that referenced
this pull request
Sep 4, 2025
*Issue #, if available:* *Description of changes:* Copying this fix in Python: aws-observability/aws-otel-python-instrumentation#458 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
jj22ee
added a commit
to aws-observability/aws-otel-java-instrumentation
that referenced
this pull request
Sep 17, 2025
*Issue #, if available:* aws-observability/aws-otel-python-instrumentation#458 *Description of changes:* 1. Remove new regions from COMMERCIAL_REGIONS 1. Rename COMMERCIAL_REGIONS to LEGACY_COMMERCIAL_REGIONS 1. Add comments for clarity By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
jj22ee
added a commit
to aws-observability/aws-otel-java-instrumentation
that referenced
this pull request
Sep 18, 2025
*Issue #, if available:* - Original issue in Python Lambda release aws-observability/aws-otel-python-instrumentation#458 - The new regions should be added to the default list, not the commercial region env variable *Description of changes:* - Cherry-pick #1185 from main ``` Remove new regions from COMMERCIAL_REGIONS Rename COMMERCIAL_REGIONS to LEGACY_COMMERCIAL_REGIONS Add comments for clarity ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
New regions were added to both
COMMERCIAL_REGIONSand the defaultaws_regionlists. From this PR, removing them fromCOMMERCIAL_REGIONSwas missed:Description of changes:
COMMERCIAL_REGIONSCOMMERCIAL_REGIONStoLEGACY_COMMERCIAL_REGIONSBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.