Only Create Fargate Profile On Deployed Fargate Task (#437)

Author: sethAmazon

terraform/eks/container_insights_agent.tf

@@ -1,33 +1,37 @@
 data "template_file" "cluster_role_file" {
+  count    = 1
   template = file("./container-insights-agent/cluster_role.tpl")
   vars = {
-    NAMESPACE = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    NAMESPACE = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
   }
   depends_on = [aws_eks_fargate_profile.test_profile]
 }
 
 data "template_file" "cluster_role_binding_file" {
+  count    = 1
   template = file("./container-insights-agent/cluster_role_binding.tpl")
   vars = {
-    NAMESPACE       = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name,
-    SERVICE_ACCOUNT = kubernetes_service_account.aoc-agent-role.metadata[0].name
+    NAMESPACE       = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name,
+    SERVICE_ACCOUNT = kubernetes_service_account.aoc-agent-role[count.index].metadata[0].name
   }
   depends_on = [aws_eks_fargate_profile.test_profile]
 }
 
 data "template_file" "config_map_file" {
+  count    = 1
   template = file("./container-insights-agent/config_map.tpl")
   vars = {
-    NAMESPACE = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    NAMESPACE = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
   }
   depends_on = [aws_eks_fargate_profile.test_profile]
 }
 
 data "template_file" "daemonset_file" {
+  count    = 1
   template = file("./container-insights-agent/daemonset.tpl")
   vars = {
-    NAMESPACE       = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
-    SERVICE_ACCOUNT = kubernetes_service_account.aoc-agent-role.metadata[0].name
+    NAMESPACE       = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    SERVICE_ACCOUNT = kubernetes_service_account.aoc-agent-role[count.index].metadata[0].name
     OTELIMAGE       = module.common.aoc_image
     REGION          = var.region
   }
@@ -39,7 +43,7 @@ resource "kubectl_manifest" "service_account" {
   yaml_body = templatefile("./container-insights-agent/service_account_fargate.yml",
     {
       RoleArn : module.iam_assumable_role_admin.iam_role_arn,
-      Namespace : tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace
+      Namespace : tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace
   })
   depends_on = [
     module.iam_assumable_role_admin,
@@ -48,34 +52,37 @@ resource "kubectl_manifest" "service_account" {
 }
 
 resource "kubectl_manifest" "cluster_role" {
-  yaml_body = var.deployment_type == "fargate" ? file("./container-insights-agent/cluster_role_fargate.yml") : data.template_file.cluster_role_file.rendered
+  count     = 1
+  yaml_body = var.deployment_type == "fargate" ? file("./container-insights-agent/cluster_role_fargate.yml") : data.template_file.cluster_role_file[count.index].rendered
 }
 
 resource "kubectl_manifest" "cluster_role_binding" {
-  yaml_body = var.deployment_type == "fargate" ? templatefile("./container-insights-agent/cluster_role_binding_fargate.yml", { Namespace : tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace }) : data.template_file.cluster_role_binding_file.rendered
+  count     = 1
+  yaml_body = var.deployment_type == "fargate" ? templatefile("./container-insights-agent/cluster_role_binding_fargate.yml", { Namespace : tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace }) : data.template_file.cluster_role_binding_file[count.index].rendered
   depends_on = [
     kubectl_manifest.cluster_role,
     aws_eks_fargate_profile.test_profile
   ]
 }
 
 resource "kubectl_manifest" "config_map" {
-  yaml_body  = var.deployment_type == "fargate" ? templatefile("./container-insights-agent/config_map_fargate.yml", { Namespace : tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace }) : data.template_file.config_map_file.rendered
+  count      = 1
+  yaml_body  = var.deployment_type == "fargate" ? templatefile("./container-insights-agent/config_map_fargate.yml", { Namespace : tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace }) : data.template_file.config_map_file[count.index].rendered
   depends_on = [aws_eks_fargate_profile.test_profile]
 }
 
 resource "kubectl_manifest" "daemonset" {
   count = var.aoc_base_scenario == "infra" && var.deployment_type != "fargate" ? 1 : 0
 
-  yaml_body = data.template_file.daemonset_file.rendered
+  yaml_body = data.template_file.daemonset_file[count.index].rendered
   depends_on = [
     kubectl_manifest.config_map
   ]
 }
 
 resource "kubectl_manifest" "aoc_service_deploy" {
   count     = var.aoc_base_scenario == "infra" && var.deployment_type == "fargate" ? 1 : 0
-  yaml_body = templatefile("./container-insights-agent/aoc_service_fargate.yml", { Namespace : tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace })
+  yaml_body = templatefile("./container-insights-agent/aoc_service_fargate.yml", { Namespace : tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace })
   depends_on = [
     kubectl_manifest.config_map,
     aws_eks_fargate_profile.test_profile
@@ -85,7 +92,7 @@ resource "kubectl_manifest" "aoc_service_deploy" {
 resource "kubectl_manifest" "aoc_fargate_deploy" {
   count = var.aoc_base_scenario == "infra" && var.deployment_type == "fargate" ? 1 : 0
   yaml_body = templatefile("./container-insights-agent/stateful_set_fargate.yml",
-  { ClusterName : var.eks_cluster_name, AocRepo : var.aoc_image_repo, AocTag : var.aoc_version, Namespace : tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace })
+  { ClusterName : var.eks_cluster_name, AocRepo : var.aoc_image_repo, AocTag : var.aoc_version, Namespace : tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace })
   depends_on = [
     kubectl_manifest.aoc_service_deploy,
     aws_eks_fargate_profile.test_profile
@@ -94,7 +101,7 @@ resource "kubectl_manifest" "aoc_fargate_deploy" {
 
 resource "kubectl_manifest" "logs_sample_fargate_deploy" {
   count     = var.aoc_base_scenario == "infra" && var.deployment_type == "fargate" ? 1 : 0
-  yaml_body = templatefile("./container-insights-agent/logs_sample_fargate.yml", { Namespace : tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace })
+  yaml_body = templatefile("./container-insights-agent/logs_sample_fargate.yml", { Namespace : tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace })
   depends_on = [
     kubectl_manifest.aoc_fargate_deploy,
     aws_eks_fargate_profile.test_profile

terraform/eks/main.tf

@@ -138,6 +138,7 @@ data "aws_subnet_ids" "private_subnets" {
 }
 
 resource "aws_eks_fargate_profile" "test_profile" {
+  count                  = var.deployment_type == "fargate" ? 1 : 0
   cluster_name           = var.eks_cluster_name
   fargate_profile_name   = "fp-aoc-${module.common.testing_id}"
   pod_execution_role_arn = aws_iam_role.fargate_profile_file.arn
@@ -160,9 +161,10 @@ resource "kubernetes_service_account" "aoc-role" {
 }
 
 resource "kubernetes_service_account" "aoc-fargate-role" {
+  count = var.deployment_type == "fargate" ? 1 : 0
   metadata {
     name      = "aoc-fargate-role-${module.common.testing_id}"
-    namespace = tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace
+    namespace = tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace
     annotations = {
       "eks.amazonaws.com/role-arn" : module.iam_assumable_role_admin.iam_role_arn
     }
@@ -189,6 +191,7 @@ module "iam_assumable_role_admin" {
 }
 
 resource "kubernetes_cluster_role_binding" "aoc-role-binding" {
+  count = 1
   metadata {
     name = "aoc-role-binding-${module.common.testing_id}"
   }
@@ -200,15 +203,16 @@ resource "kubernetes_cluster_role_binding" "aoc-role-binding" {
   subject {
     kind      = "ServiceAccount"
     name      = var.deployment_type == "fargate" ? "aoc-fargate-role-${module.common.testing_id}" : "aoc-role-${module.common.testing_id}"
-    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
   }
   depends_on = [aws_eks_fargate_profile.test_profile]
 }
 
 resource "kubernetes_service_account" "aoc-agent-role" {
+  count = 1
   metadata {
     name      = "aoc-agent-${module.common.testing_id}"
-    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
   }
 
   automount_service_account_token = true

terraform/eks/otlp.tf

@@ -43,7 +43,7 @@ module "aoc_oltp" {
     listen_address_ip   = module.common.sample_app_listen_address_ip
     listen_address_port = module.common.sample_app_listen_address_port
   }
-  aoc_namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+  aoc_namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
   aoc_service = {
     name      = module.common.otel_service_name
     grpc_port = module.common.grpc_port
@@ -64,7 +64,7 @@ resource "kubernetes_config_map" "aoc_config_map" {
 
   metadata {
     name      = "otel-config"
-    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
   }
 
   data = {
@@ -79,7 +79,7 @@ resource "kubernetes_config_map" "mocked_server_cert" {
 
   metadata {
     name      = "mocked-server-cert"
-    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
   }
 
   data = {
@@ -94,7 +94,7 @@ resource "kubernetes_deployment" "aoc_deployment" {
 
   metadata {
     name      = "aoc"
-    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
     labels = {
       app = "aoc"
     }
@@ -186,7 +186,7 @@ resource "kubernetes_service" "mocked_server_service" {
 
   metadata {
     name      = "mocked-server"
-    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
   }
   spec {
     selector = {
@@ -207,7 +207,7 @@ data "template_file" "adot_collector_config_file" {
   template = file("./adot-operator/adot_collector_deployment.tpl")
 
   vars = {
-    AOC_NAMESPACE      = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    AOC_NAMESPACE      = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
     AOC_IMAGE          = module.common.aoc_image
     AOC_DEPLOY_MODE    = var.aoc_deploy_mode
     AOC_SERVICEACCOUNT = "aoc-role-${module.common.testing_id}"
@@ -241,7 +241,7 @@ resource "kubernetes_service" "sample_app_service" {
 
   metadata {
     name      = "sample-app"
-    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
   }
   spec {
     selector = {
@@ -263,7 +263,7 @@ resource "kubernetes_ingress" "app" {
   wait_for_load_balancer = true
   metadata {
     name      = "sample-app-ingress"
-    namespace = tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace
+    namespace = tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace
     annotations = {
       "kubernetes.io/ingress.class"           = "alb"
       "alb.ingress.kubernetes.io/scheme"      = "internet-facing"

terraform/eks/prometheus.tf

@@ -2,7 +2,7 @@ resource "kubernetes_deployment" "standalone_aoc_deployment" {
   count = var.aoc_base_scenario == "prometheus" ? 1 : 0
   metadata {
     name      = "aoc"
-    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile.selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
+    namespace = var.deployment_type == "fargate" ? tolist(aws_eks_fargate_profile.test_profile[count.index].selector)[0].namespace : kubernetes_namespace.aoc_ns.metadata[0].name
     labels = {
       app = "aoc"
     }