Skip to content

Commit a245bfa

Browse files
committed
Added changes to make validator work with x-ray
1 parent 4bd9b02 commit a245bfa

File tree

8 files changed

+87
-5
lines changed

8 files changed

+87
-5
lines changed

validator/src/main/java/com/amazon/aoc/fileconfigs/ExpectedTrace.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,10 @@
2020
@Getter
2121
public enum ExpectedTrace implements FileConfig {
2222
DEFAULT_EXPECTED_TRACE("/expected-data-template/defaultExpectedTrace.mustache"),
23-
AWSSDK_EXPECTED_TRACE("/expected-data-template/expectedAWSSDKTrace.mustache"),
24-
HTTP_EXPECTED_TRACE("/expected-data-template/expectedHTTPTrace.mustache")
23+
OTEL_SDK_AWSSDK_EXPECTED_TRACE("/expected-data-template/otelSDKexpectedAWSSDKTrace.mustache"),
24+
OTEL_SDK_HTTP_EXPECTED_TRACE("/expected-data-template/otelSDKexpectedHTTPTrace.mustache"),
25+
XRAY_SDK_AWSSDK_EXPECTED_TRACE("/expected-data-template/xraySDKexpectedAWSSDKTrace.mustache"),
26+
XRAY_SDK_HTTP_EXPECTED_TRACE("/expected-data-template/xraySDKexpectedHTTPTrace.mustache"),
2527
;
2628

2729
private String path;

validator/src/main/java/com/amazon/aoc/helpers/RetryHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public static void retry(
4141
retryable.execute();
4242
return;
4343
} catch (Exception ex) {
44-
log.info("retrying after 10 seconds");
44+
log.info("retrying after {} seconds", TimeUnit.MILLISECONDS.toSeconds(sleepInMilliSeconds));
4545

4646
if (retryCount == 0) {
4747
log.error("retries exhausted, possible exception: ", ex);
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
{
2+
"name": "My Flask Web Application",
3+
"in_progress": false,
4+
"http": {
5+
"request": {
6+
"url": "{{endpoint}}/aws-sdk-call",
7+
"method": "GET"
8+
},
9+
"response": {
10+
"status": 200
11+
}
12+
},
13+
"aws": {
14+
"xray": {
15+
"sampling_rule_name": "Default"
16+
}
17+
},
18+
"subsegments": [
19+
{
20+
"name": "S3",
21+
"in_progress": false,
22+
"http": {
23+
"response": {
24+
"status": 200
25+
}
26+
},
27+
"aws": {
28+
"region": "{{region}}",
29+
"operation": "ListBuckets"
30+
},
31+
"namespace": "aws"
32+
}
33+
]
34+
}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
{
2+
"name": "My Flask Web Application",
3+
"in_progress": false,
4+
"http": {
5+
"request": {
6+
"url": "{{endpoint}}/outgoing-http-call",
7+
"method": "GET"
8+
},
9+
"response": {
10+
"status": 200
11+
}
12+
},
13+
"aws": {
14+
"xray": {
15+
"sampling_rule_name": "Default"
16+
}
17+
},
18+
"subsegments": [
19+
{
20+
"name": "aws.amazon.com",
21+
"in_progress": false,
22+
"http": {
23+
"request": {
24+
"url": "https://aws.amazon.com",
25+
"method": "get"
26+
},
27+
"response": {
28+
"status": 200
29+
}
30+
},
31+
"namespace": "remote"
32+
}
33+
]
34+
}
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
-
2+
validationType: "trace"
3+
httpPath: "/outgoing-http-call"
4+
httpMethod: "get"
5+
callingType: "http"
6+
expectedTraceTemplate: "OTEL_SDK_HTTP_EXPECTED_TRACE"
7+
-
8+
validationType: "trace"
9+
httpPath: "/aws-sdk-call"
10+
httpMethod: "get"
11+
callingType: "http"
12+
expectedTraceTemplate: "OTEL_SDK_AWSSDK_EXPECTED_TRACE"

validator/src/main/resources/validations/default-trace-validation.yml renamed to validator/src/main/resources/validations/default-xray-trace-validation.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
httpPath: "/outgoing-http-call"
44
httpMethod: "get"
55
callingType: "http"
6-
expectedTraceTemplate: "HTTP_EXPECTED_TRACE"
6+
expectedTraceTemplate: "XRAY_SDK_HTTP_EXPECTED_TRACE"
77
-
88
validationType: "trace"
99
httpPath: "/aws-sdk-call"
1010
httpMethod: "get"
1111
callingType: "http"
12-
expectedTraceTemplate: "AWSSDK_EXPECTED_TRACE"
12+
expectedTraceTemplate: "XRAY_SDK_AWSSDK_EXPECTED_TRACE"

0 commit comments

Comments
 (0)