Skip to content

Commit b71aaa9

Browse files
authored
fix: Remove error flag from x-ray trace root. (#211)
1 parent 12c4568 commit b71aaa9

File tree

4 files changed

+2
-5
lines changed

4 files changed

+2
-5
lines changed

.github/workflows/ci.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: AWS RUM Web Client Continuous Build
22

33
on:
44
push:
5-
branches: [main]
5+
branches: [main, release-*.*.*]
66
pull_request:
7-
branches: [main]
7+
branches: [main, release-*.*.*]
88

99
concurrency:
1010
group: ${{ github.workflow }}-${{ github.ref }}

src/plugins/event-plugins/FetchPlugin.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ export class FetchPlugin extends MonkeyPatched<Window, 'fetch'> {
151151
xRayTraceEvent.throttle = true;
152152
} else if (is4xx(response.status)) {
153153
xRayTraceEvent.subsegments[0].error = true;
154-
xRayTraceEvent.error = true;
155154
} else if (is5xx(response.status)) {
156155
xRayTraceEvent.subsegments[0].fault = true;
157156
xRayTraceEvent.fault = true;

src/plugins/event-plugins/XhrPlugin.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ export class XhrPlugin extends MonkeyPatched<XMLHttpRequest, 'send' | 'open'> {
150150
xhrDetails.trace.throttle = true;
151151
} else if (is4xx(xhr.status)) {
152152
xhrDetails.trace.subsegments[0].error = true;
153-
xhrDetails.trace.error = true;
154153
} else if (is5xx(xhr.status)) {
155154
xhrDetails.trace.subsegments[0].fault = true;
156155
xhrDetails.trace.fault = true;

src/plugins/event-plugins/__tests__/FetchPlugin.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,6 @@ describe('FetchPlugin tests', () => {
290290

291291
// Assert
292292
expect(record.mock.calls[0][1]).toMatchObject({
293-
error: true,
294293
subsegments: [
295294
{
296295
error: true,

0 commit comments

Comments
 (0)