Skip to content

Commit 850ce80

Browse files
bonclay7vchintal
andauthored
Plan tests (#166)
* Updated plan-examples.yml to support e2e tests for multi cluster example (#165) * Updated plan-examples.yml to support e2e tests for multi cluster example * Put the variables in right place with right values * (to drop): Allow running tests in branch --------- Co-authored-by: Rodrigue Koffi <[email protected]> * Force running tests * Update plan-examples.yml --------- Co-authored-by: Vijay Chintalapati <[email protected]>
1 parent 0cc8dc5 commit 850ce80

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

.github/workflows/plan-examples.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ on:
55
pull_request_target:
66
branches:
77
- main
8+
# this will allow to run test on main and not modify the status badge when opening a PR
9+
push:
10+
branches: ["main"]
11+
812
workflow_dispatch:
913

1014
concurrency:
@@ -90,6 +94,8 @@ jobs:
9094
TF_VAR_aws_region: us-west-2
9195
TF_VAR_managed_grafana_workspace_id: ${{ secrets.GRAFANA_WORKSPACE_ID }}
9296
TF_VAR_eks_cluster_id: e2e-tests
97+
TF_VAR_eks_cluster_1_id: e2e-tests
98+
TF_VAR_eks_cluster_2_id: e2e-tests
9399
TF_VAR_managed_prometheus_workspace_ids: ${{ secrets.PROMETHEUS_WORKSPACE_ID }}
94100
with:
95101
project-name: terraform-plan
@@ -98,7 +104,9 @@ jobs:
98104
TF_VAR_aws_region,
99105
TF_VAR_managed_grafana_workspace_id,
100106
TF_VAR_eks_cluster_id,
101-
TF_VAR_managed_prometheus_workspace_ids
107+
TF_VAR_managed_prometheus_workspace_ids,
108+
TF_VAR_eks_cluster_1_id,
109+
TF_VAR_eks_cluster_2_id
102110
buildspec-override: |
103111
version: 0.2
104112
phases:

.github/workflows/pre-commit.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ on:
88
- '**.tf'
99
- '**.yml'
1010
- '**.yaml'
11+
push:
12+
branches: ["main"]
13+
paths:
14+
- '**.tf'
15+
- '**.yml'
16+
- '**.yaml'
1117

1218
env:
1319
TERRAFORM_DOCS_VERSION: v0.16.0

examples/eks-multicluster/main.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ module "eks_cluster_2_monitoring" {
6565
enable_cert_manager = true
6666
enable_java = true
6767

68-
# Since the following were enabled in conjunction with the set up of the eks_cluster_1 EKS cluster, we will skip
69-
# them with the eks_cluster_2 EKS cluster
68+
# Since the following were enabled in conjunction with the set up of the
69+
# eks_cluster_1 EKS cluster, we will skip them with the eks_cluster_2 EKS cluster
7070
enable_dashboards = false
7171
enable_alerting_rules = false
7272
enable_recording_rules = false

0 commit comments

Comments
 (0)