Move plan tests to AWS CodeBuild (#152)

bonclay7 · web-flow · commit b513fe4e72e6 · 2023-04-13T15:23:35.000+02:00
* Add plan test on CodeBuild

* (to revert) remove changes filter

* (to revert) allow running on current branch

* (to revert) run assume role always

* Fix terraform state s3 keys for ci tests

* Add defaults for e2e

* Fix bucket name

* Debug clone version

* Pass build version

* Use actions env syntax

* fixup! Use actions env syntax

* fixup! fixup! Use actions env syntax

* fixup! fixup! fixup! Use actions env syntax

* Add input for amp monitoring

* Update e2e cluster name

* use credentials v2

* Cleanup

* Add build badge

* Revert triggers settings
diff --git a/.github/workflows/plan-examples.yml b/.github/workflows/plan-examples.yml
@@ -75,29 +75,42 @@ jobs:
               - '*.tf'
 
       - name: Configure AWS credentials from Test account
-        uses: aws-actions/configure-aws-credentials@v1
+        uses: aws-actions/configure-aws-credentials@v2
         if: steps.changes.outputs.src== 'true'
         with:
           role-to-assume: ${{ secrets.ROLE_TO_ASSUME }}
           aws-region: us-west-2
           role-duration-seconds: 3600
           role-session-name: GithubActions-Session
 
-      - name: Terraform Job
-        uses: hashicorp/setup-terraform@v2
+      - name: Terraform plan from CodeBuild
         if: steps.changes.outputs.src== 'true'
+        uses: aws-actions/aws-codebuild-run-build@v1
+        env:
+          TF_VAR_aws_region: us-west-2
+          TF_VAR_managed_grafana_workspace_id: ${{ secrets.GRAFANA_WORKSPACE_ID }}
+          TF_VAR_eks_cluster_id: e2e-tests
+          TF_VAR_managed_prometheus_workspace_ids: ${{ secrets.PROMETHEUS_WORKSPACE_ID }}
         with:
-          terraform_version: 1.2.9
-
-      - if: steps.changes.outputs.src== 'true'
-        run: terraform version
-
-      - name: Terraform Init
-        if: steps.changes.outputs.src== 'true'
-        run: terraform init -reconfigure
-        working-directory: ${{ matrix.directory }}
-
-      - name: Terraform Plan
-        if: steps.changes.outputs.src== 'true'
-        working-directory: ${{ matrix.directory }}
-        run: terraform plan -no-color
+          project-name: terraform-plan
+          disable-source-override: false
+          env-vars-for-codebuild: |
+            TF_VAR_aws_region,
+            TF_VAR_managed_grafana_workspace_id,
+            TF_VAR_eks_cluster_id,
+            TF_VAR_managed_prometheus_workspace_ids
+          buildspec-override: |
+            version: 0.2
+            phases:
+              build:
+                commands:
+                   - export TF_VAR_grafana_api_key="fakeapikey"
+                   - curl -fsSL https://apt.releases.hashicorp.com/gpg | sudo apt-key add -
+                   - sudo apt-add-repository "deb [arch=amd64] https://apt.releases.hashicorp.com $(lsb_release -cs) main"
+                   - sudo apt-get update && sudo apt-get install terraform
+                   - terraform -version
+                   - aws --version
+                   - cd ${{ matrix.directory }}
+                   - sed -i 's/#//' versions.tf
+                   - terraform init
+                   - terraform plan
diff --git a/README.md b/README.md
@@ -1,6 +1,7 @@
 # AWS Observability Accelerator for Terraform
 
 [![pre-commit](https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/workflows/pre-commit.yaml/badge.svg)](https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/workflows/pre-commit.yaml)
+[![plan-examples](https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/workflows/plan-examples.yml/badge.svg)](https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/workflows/plan-examples.yml)
 
 Welcome to the AWS Observability Accelerator for Terraform!
 
diff --git a/examples/eks-cluster-with-vpc/variables.tf b/examples/eks-cluster-with-vpc/variables.tf
@@ -1,7 +1,7 @@
 variable "cluster_name" {
   description = "Name of cluster - used by Terratest for e2e test automation"
   type        = string
-  default     = ""
+  default     = "eks-cluster-with-vpc"
 
   validation {
     # cluster name is used as prefix on eks_blueprint module and cannot be >25 characters
diff --git a/examples/eks-cluster-with-vpc/versions.tf b/examples/eks-cluster-with-vpc/versions.tf
@@ -26,7 +26,7 @@ terraform {
 
   # ##  Used for end-to-end testing on project; update to suit your needs
   # backend "s3" {
-  #   bucket = "observability-accelerator-terraform-states"
+  #   bucket = "aws-observability-accelerator-terraform-states"
   #   region = "us-west-2"
   #   key    = "e2e/eks-cluster-with-vpc/terraform.tfstate"
   # }
diff --git a/examples/existing-cluster-java/versions.tf b/examples/existing-cluster-java/versions.tf
@@ -26,9 +26,9 @@ terraform {
 
   # ##  Used for end-to-end testing on project; update to suit your needs
   # backend "s3" {
-  #   bucket = "observability-accelerator-terraform-states"
+  #   bucket = "aws-observability-accelerator-terraform-states"
   #   region = "us-west-2"
-  #   key    = "e2e/existing-cluster-with-base-and-infra/terraform.tfstate"
+  #   key    = "e2e/existing-cluster-java/terraform.tfstate"
   # }
 
 }
diff --git a/examples/existing-cluster-nginx/versions.tf b/examples/existing-cluster-nginx/versions.tf
@@ -26,9 +26,9 @@ terraform {
 
   # ##  Used for end-to-end testing on project; update to suit your needs
   # backend "s3" {
-  #   bucket = "observability-accelerator-terraform-states"
+  #   bucket = "aws-observability-accelerator-terraform-states"
   #   region = "us-west-2"
-  #   key    = "e2e/existing-cluster-with-base-and-infra/terraform.tfstate"
+  #   key    = "e2e/existing-cluster-nginx/terraform.tfstate"
   # }
 
 }
diff --git a/examples/existing-cluster-with-base-and-infra/versions.tf b/examples/existing-cluster-with-base-and-infra/versions.tf
@@ -26,7 +26,7 @@ terraform {
 
   # ##  Used for end-to-end testing on project; update to suit your needs
   # backend "s3" {
-  #   bucket = "observability-accelerator-terraform-states"
+  #   bucket = "aws-observability-accelerator-terraform-states"
   #   region = "us-west-2"
   #   key    = "e2e/existing-cluster-with-base-and-infra/terraform.tfstate"
   # }
diff --git a/examples/managed-grafana-workspace/versions.tf b/examples/managed-grafana-workspace/versions.tf
@@ -7,4 +7,11 @@ terraform {
       version = ">= 4.0.0"
     }
   }
+
+  # ##  Used for end-to-end testing on project; update to suit your needs
+  # backend "s3" {
+  #   bucket = "aws-observability-accelerator-terraform-states"
+  #   region = "us-west-2"
+  #   key    = "e2e/managed-grafana-workspace/terraform.tfstate"
+  # }
 }
diff --git a/examples/managed-prometheus-monitoring/versions.tf b/examples/managed-prometheus-monitoring/versions.tf
@@ -11,4 +11,11 @@ terraform {
       version = ">= 1.25.0"
     }
   }
+
+  # ##  Used for end-to-end testing on project; update to suit your needs
+  # backend "s3" {
+  #   bucket = "aws-observability-accelerator-terraform-states"
+  #   region = "us-west-2"
+  #   key    = "e2e/managed-prometheus-monitoring/terraform.tfstate"
+  # }
 }

Original file line number	Diff line number	Diff line change
`@@ -7,4 +7,11 @@ terraform {`
`7`	`7`	`version = ">= 4.0.0"`
`8`	`8`	`}`
`9`	`9`	`}`
	`10`	`+`
	`11`	`+ # ## Used for end-to-end testing on project; update to suit your needs`
	`12`	`+ # backend "s3" {`
	`13`	`+ # bucket = "aws-observability-accelerator-terraform-states"`
	`14`	`+ # region = "us-west-2"`
	`15`	`+ # key = "e2e/managed-grafana-workspace/terraform.tfstate"`
	`16`	`+ # }`
`10`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,4 +11,11 @@ terraform {`
`11`	`11`	`version = ">= 1.25.0"`
`12`	`12`	`}`
`13`	`13`	`}`
	`14`	`+`
	`15`	`+ # ## Used for end-to-end testing on project; update to suit your needs`
	`16`	`+ # backend "s3" {`
	`17`	`+ # bucket = "aws-observability-accelerator-terraform-states"`
	`18`	`+ # region = "us-west-2"`
	`19`	`+ # key = "e2e/managed-prometheus-monitoring/terraform.tfstate"`
	`20`	`+ # }`
`14`	`21`	`}`