refactor: make ParseAssemblyName static and enhance error handling in assembly name parsing

Author: hjgraca

libraries/src/AWS.Lambda.Powertools.Common/Core/PowertoolsEnvironment.cs

@@ -117,26 +117,26 @@ public void SetExecutionEnvironment<T>(T type)
     /// </summary>
     /// <param name="assemblyName"></param>
     /// <returns></returns>
-    internal string ParseAssemblyName(string assemblyName)
+    internal static string ParseAssemblyName(string assemblyName)
     {
         // Use cache to avoid repeated string operations
-        return ParsedAssemblyNameCache.GetOrAdd(assemblyName, name =>
+        try
         {
-            try
+            return ParsedAssemblyNameCache.GetOrAdd(assemblyName, name =>
             {
                 var lastDotIndex = name.LastIndexOf('.');
                 if (lastDotIndex >= 0 && lastDotIndex < name.Length - 1)
                 {
                     var parsedName = name.Substring(lastDotIndex + 1);
                     return $"{Constants.FeatureContextIdentifier}/{parsedName}";
                 }
-            }
-            catch
-            {
-                //NOOP
-            }
 
-            return $"{Constants.FeatureContextIdentifier}/{name}";
-        });
+                return $"{Constants.FeatureContextIdentifier}/{name}";
+            });
+        }
+        catch (Exception e)
+        {
+            return string.Empty;
+        }
     }
 }

libraries/tests/AWS.Lambda.Powertools.Common.Tests/Core/PowertoolsEnvironmentTest.cs

@@ -235,11 +235,8 @@ public void GetAssemblyVersion_Should_Handle_Regular_Object()
     [Fact]
     public void ParseAssemblyName_Should_Handle_Assembly_Without_Dots()
     {
-        // Arrange
-        var powertoolsEnv = new PowertoolsEnvironment();
-        
         // Act
-        var result = powertoolsEnv.ParseAssemblyName("SimpleAssemblyName");
+        var result = PowertoolsEnvironment.ParseAssemblyName("SimpleAssemblyName");
 
         // Assert
         Assert.Equal($"{Constants.FeatureContextIdentifier}/SimpleAssemblyName", result);
@@ -248,11 +245,8 @@ public void ParseAssemblyName_Should_Handle_Assembly_Without_Dots()
     [Fact]
     public void ParseAssemblyName_Should_Handle_Assembly_With_Dots()
     {
-        // Arrange
-        var powertoolsEnv = new PowertoolsEnvironment();
-        
         // Act
-        var result = powertoolsEnv.ParseAssemblyName("AWS.Lambda.Powertools.Common");
+        var result = PowertoolsEnvironment.ParseAssemblyName("AWS.Lambda.Powertools.Common");
 
         // Assert
         Assert.Equal($"{Constants.FeatureContextIdentifier}/Common", result);
@@ -261,18 +255,25 @@ public void ParseAssemblyName_Should_Handle_Assembly_With_Dots()
     [Fact]
     public void ParseAssemblyName_Should_Use_Cache_For_Same_Assembly_Name()
     {
-        // Arrange
-        var powertoolsEnv = new PowertoolsEnvironment();
-        
         // Act - Call twice with same assembly name
-        var result1 = powertoolsEnv.ParseAssemblyName("AWS.Lambda.Powertools.Tests");
-        var result2 = powertoolsEnv.ParseAssemblyName("AWS.Lambda.Powertools.Tests");
+        var result1 = PowertoolsEnvironment.ParseAssemblyName("AWS.Lambda.Powertools.Tests");
+        var result2 = PowertoolsEnvironment.ParseAssemblyName("AWS.Lambda.Powertools.Tests");
 
         // Assert - Should return same result (cached)
         Assert.Equal(result1, result2);
         Assert.Equal($"{Constants.FeatureContextIdentifier}/Tests", result1);
     }
 
+    [Fact]
+    public void ParseAssemblyName_Null_Return_Empty()
+    {
+        // Act - Call twice with same assembly name
+        var result = PowertoolsEnvironment.ParseAssemblyName(null);
+        
+        // Assert - Should return null
+        Assert.Empty(result);
+    }
+    
     [Fact]
     public void SetExecutionEnvironment_Should_Handle_Empty_Current_Environment()
     {