Skip to content

Commit 10d2244

Browse files
committed
Have made the SetDefaultDimensions smaller by removing the check on the global DefaultDimensions and Instead checking if the passed variable is empty if so return so we don't delete the default, other wise set the Default to the passed ones
1 parent dba5e90 commit 10d2244

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

libraries/src/AWS.Lambda.Powertools.Metrics/Model/MetricDirective.cs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -199,12 +199,10 @@ internal void AddDimension(DimensionSet dimension)
199199
/// <param name="defaultDimensions">Default dimensions list</param>
200200
internal void SetDefaultDimensions(List<DimensionSet> defaultDimensions)
201201
{
202-
if (!DefaultDimensions.Any())
203-
DefaultDimensions = defaultDimensions;
204-
else
205-
foreach (var item in defaultDimensions)
206-
if (!DefaultDimensions.Any(d => d.DimensionKeys.Contains(item.DimensionKeys[0])))
207-
DefaultDimensions.Add(item);
202+
if (!defaultDimensions.Any())
203+
return;
204+
205+
DefaultDimensions = defaultDimensions;
208206
}
209207

210208
/// <summary>

0 commit comments

Comments
 (0)