Addressing analysed warnings.

Author: hjgraca

libraries/src/AWS.Lambda.Powertools.Idempotency/Internal/LRUCache.cs

@@ -11,6 +11,7 @@ namespace AWS.Lambda.Powertools.Idempotency.Internal;
 /// </summary>
 /// <typeparam name="TKey">The type of the key to the cached item.</typeparam>
 /// <typeparam name="TValue">The type of the cached item.</typeparam>
+// ReSharper disable once InconsistentNaming
 internal sealed class LRUCache<TKey, TValue>
 {
     /// <summary>

libraries/tests/AWS.Lambda.Powertools.Idempotency.Tests/Handlers/IdempotencyFunction.cs

@@ -21,7 +21,6 @@
 using System.Threading.Tasks;
 using Amazon.DynamoDBv2;
 using Amazon.Lambda.APIGatewayEvents;
-using Amazon.Lambda.Core;
 
 namespace AWS.Lambda.Powertools.Idempotency.Tests.Handlers;
 
@@ -45,15 +44,15 @@ public IdempotencyFunction(AmazonDynamoDBClient client)
     }
 
     [Idempotent]
-    public async Task<APIGatewayProxyResponse> Handle(APIGatewayProxyRequest apigProxyEvent, ILambdaContext context)
+    public async Task<APIGatewayProxyResponse> Handle(APIGatewayProxyRequest apigProxyEvent)
     {
         HandlerExecuted = true;
 
-        var result= await InternalFunctionHandler(apigProxyEvent,context);
+        var result= await InternalFunctionHandler(apigProxyEvent);
 
         return result;
     }
-    private async Task<APIGatewayProxyResponse> InternalFunctionHandler(APIGatewayProxyRequest apigProxyEvent, ILambdaContext context)
+    private async Task<APIGatewayProxyResponse> InternalFunctionHandler(APIGatewayProxyRequest apigProxyEvent)
     {
         Dictionary<string, string> headers = new()
         {

libraries/tests/AWS.Lambda.Powertools.Idempotency.Tests/IdempotencyTest.cs

@@ -19,7 +19,6 @@
 using Amazon.DynamoDBv2;
 using Amazon.DynamoDBv2.Model;
 using Amazon.Lambda.APIGatewayEvents;
-using Amazon.Lambda.TestUtilities;
 using AWS.Lambda.Powertools.Idempotency.Tests.Handlers;
 using AWS.Lambda.Powertools.Idempotency.Tests.Persistence;
 using FluentAssertions;
@@ -49,16 +48,14 @@ public async Task EndToEndTest()
             PropertyNameCaseInsensitive = true
         };
 
-        //var persistenceStore = new InMemoryPersistenceStore();
-        var context = new TestLambdaContext();
         var request = JsonSerializer.Deserialize<APIGatewayProxyRequest>(await File.ReadAllTextAsync("./resources/apigw_event2.json"),options);
 
-        var response = await function.Handle(request, context);
+        var response = await function.Handle(request);
         function.HandlerExecuted.Should().BeTrue();
 
         function.HandlerExecuted = false;
 
-        var response2 = await function.Handle(request, context);
+        var response2 = await function.Handle(request);
         function.HandlerExecuted.Should().BeFalse();
 
         JsonSerializer.Serialize(response).Should().Be(JsonSerializer.Serialize(response));

libraries/tests/AWS.Lambda.Powertools.Idempotency.Tests/Internal/LRUCacheTests.cs

@@ -21,6 +21,7 @@
 //Source: https://github.dev/microsoft/botbuilder-dotnet/blob/main/tests/AdaptiveExpressions.Tests/LRUCacheTest.cs
 namespace AWS.Lambda.Powertools.Idempotency.Tests.Internal;
 
+// ReSharper disable once InconsistentNaming
 public class LRUCacheTests
 {
     [Fact]
@@ -58,7 +59,7 @@ public void TestDiacardPolicy()
     /*
      * The average time of this test is about 2ms. 
      */
-    public void TestDPMemorySmall()
+    public void TestDpMemorySmall()
     {
         var cache = new LRUCache<int, int>(2);
         cache.Set(0, 1);
@@ -87,7 +88,7 @@ public void TestDPMemorySmall()
      * The average time of this test is about 3ms. 
      */
     [Fact]
-    public void TestDPMemoryLarge()
+    public void TestDpMemoryLarge()
     {
         var cache = new LRUCache<int, int>(500);
         cache.Set(0, 1);
@@ -123,7 +124,6 @@ public async Task TestMultiThreadingAsync()
         const int numOfOps = 1000;
         for (var i = 0; i < numOfThreads; i++)
         {
-            var idx = i;
             tasks.Add(Task.Run(() => StoreElement(cache, numOfOps)));
         }
 

libraries/tests/AWS.Lambda.Powertools.Idempotency.Tests/Persistence/DynamoDBFixture.cs

@@ -18,7 +18,6 @@
 using Amazon.DynamoDBv2;
 using Amazon.DynamoDBv2.Model;
 using Amazon.Runtime;
-using AWS.Lambda.Powertools.Idempotency.Persistence;
 using DotNet.Testcontainers.Builders;
 using DotNet.Testcontainers.Containers;