Skip to content

Commit 120b8d0

Browse files
committed
Fix namespace regex and fix metrics e2e tests.
1 parent 6b82ea5 commit 120b8d0

File tree

2 files changed

+14
-15
lines changed
  • powertools-e2e-tests/handlers/metrics/src/main/java/software/amazon/lambda/powertools/e2e
  • powertools-metrics/src/main/java/software/amazon/lambda/powertools/metrics/internal

2 files changed

+14
-15
lines changed

powertools-e2e-tests/handlers/metrics/src/main/java/software/amazon/lambda/powertools/e2e/Function.java

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,36 +16,35 @@
1616

1717
import com.amazonaws.services.lambda.runtime.Context;
1818
import com.amazonaws.services.lambda.runtime.RequestHandler;
19-
import software.amazon.cloudwatchlogs.emf.logger.MetricsLogger;
20-
import software.amazon.cloudwatchlogs.emf.model.DimensionSet;
21-
import software.amazon.cloudwatchlogs.emf.model.StorageResolution;
22-
import software.amazon.cloudwatchlogs.emf.model.Unit;
2319
import software.amazon.lambda.powertools.metrics.FlushMetrics;
24-
import software.amazon.lambda.powertools.metrics.MetricsUtils;
20+
import software.amazon.lambda.powertools.metrics.Metrics;
21+
import software.amazon.lambda.powertools.metrics.MetricsFactory;
22+
import software.amazon.lambda.powertools.metrics.model.DimensionSet;
23+
import software.amazon.lambda.powertools.metrics.model.MetricResolution;
24+
import software.amazon.lambda.powertools.metrics.model.MetricUnit;
2525
import java.time.LocalDateTime;
2626
import java.time.ZoneOffset;
2727
import java.time.temporal.ChronoUnit;
2828
import java.time.Instant;
2929

30-
3130
public class Function implements RequestHandler<Input, String> {
3231

33-
MetricsLogger metricsLogger = MetricsUtils.metricsLogger();
32+
Metrics metrics = MetricsFactory.getMetricsInstance();
3433

3534
@FlushMetrics(captureColdStart = true)
3635
public String handleRequest(Input input, Context context) {
3736

38-
Instant currentTimeTruncatedPlusThirty =
39-
LocalDateTime.now().truncatedTo(ChronoUnit.MINUTES).toInstant(ZoneOffset.UTC).plusSeconds(30);
40-
metricsLogger.setTimestamp(currentTimeTruncatedPlusThirty);
37+
Instant currentTimeTruncatedPlusThirty = LocalDateTime.now().truncatedTo(ChronoUnit.MINUTES)
38+
.toInstant(ZoneOffset.UTC).plusSeconds(30);
39+
metrics.setTimestamp(currentTimeTruncatedPlusThirty);
4140

4241
DimensionSet dimensionSet = new DimensionSet();
4342
input.getDimensions().forEach((key, value) -> dimensionSet.addDimension(key, value));
44-
metricsLogger.putDimensions(dimensionSet);
43+
metrics.addDimension(dimensionSet);
4544

46-
input.getMetrics().forEach((key, value) -> metricsLogger.putMetric(key, value, Unit.COUNT,
47-
input.getHighResolution().equalsIgnoreCase("true") ? StorageResolution.HIGH :
48-
StorageResolution.STANDARD));
45+
input.getMetrics().forEach((key, value) -> metrics.addMetric(key, value, MetricUnit.COUNT,
46+
input.getHighResolution().equalsIgnoreCase("true") ? MetricResolution.HIGH
47+
: MetricResolution.STANDARD));
4948

5049
return "OK";
5150
}

powertools-metrics/src/main/java/software/amazon/lambda/powertools/metrics/internal/Validator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public class Validator {
2626
private static final int MAX_DIMENSION_NAME_LENGTH = 250;
2727
private static final int MAX_DIMENSION_VALUE_LENGTH = 1024;
2828
private static final int MAX_NAMESPACE_LENGTH = 255;
29-
private static final String NAMESPACE_REGEX = "^[a-zA-Z0-9.-_#/:]+$";
29+
private static final String NAMESPACE_REGEX = "^[a-zA-Z0-9._#:/-]+$";
3030
public static final long MAX_TIMESTAMP_PAST_AGE_SECONDS = TimeUnit.DAYS.toSeconds(14);
3131
public static final long MAX_TIMESTAMP_FUTURE_AGE_SECONDS = TimeUnit.HOURS.toSeconds(2);
3232

0 commit comments

Comments
 (0)