Skip to content

Commit 3379be6

Browse files
Rename annotation to make it consistent with logger (#32)
1 parent 32d2c42 commit 3379be6

File tree

8 files changed

+21
-20
lines changed

8 files changed

+21
-20
lines changed

example/HelloWorldFunction/src/main/java/helloworld/App.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import org.apache.logging.log4j.Logger;
1919
import software.amazon.lambda.logging.PowerLogger;
2020
import software.amazon.lambda.logging.PowerToolsLogging;
21-
import software.amazon.lambda.tracing.PowerToolTracing;
21+
import software.amazon.lambda.tracing.PowerToolsTracing;
2222
import software.amazon.lambda.tracing.PowerTracer;
2323

2424
import static software.amazon.lambda.tracing.PowerTracer.putMetadata;
@@ -32,9 +32,10 @@ public class App implements RequestHandler<APIGatewayProxyRequestEvent, APIGatew
3232
Logger log = LogManager.getLogger();
3333

3434
@PowerToolsLogging(logEvent = true)
35-
@PowerToolTracing
35+
@PowerToolsTracing
3636
public APIGatewayProxyResponseEvent handleRequest(final APIGatewayProxyRequestEvent input, final Context context) {
3737
Map<String, String> headers = new HashMap<>();
38+
3839
headers.put("Content-Type", "application/json");
3940
headers.put("X-Custom-Header", "application/json");
4041

@@ -89,13 +90,13 @@ private void threadOption2() throws InterruptedException {
8990
anotherThread.join();
9091
}
9192

92-
@PowerToolTracing
93+
@PowerToolsTracing
9394
private void log() {
9495
log.info("inside threaded logging for function");
9596
}
9697

9798

98-
@PowerToolTracing(namespace = "getPageContents", captureResponse = false, captureError = false)
99+
@PowerToolsTracing(namespace = "getPageContents", captureResponse = false, captureError = false)
99100
private String getPageContents(String address) throws IOException {
100101
URL url = new URL(address);
101102
putMetadata("getPageContents", address);

src/main/java/software/amazon/lambda/tracing/PowerToolTracing.java renamed to src/main/java/software/amazon/lambda/tracing/PowerToolsTracing.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
@Retention(RetentionPolicy.RUNTIME)
99
@Target(ElementType.METHOD)
10-
public @interface PowerToolTracing {
10+
public @interface PowerToolsTracing {
1111
String namespace() default "";
1212
boolean captureResponse() default true;
1313
boolean captureError() default true;

src/main/java/software/amazon/lambda/tracing/internal/LambdaTracingAspect.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import org.aspectj.lang.annotation.Around;
88
import org.aspectj.lang.annotation.Aspect;
99
import org.aspectj.lang.annotation.Pointcut;
10-
import software.amazon.lambda.tracing.PowerToolTracing;
10+
import software.amazon.lambda.tracing.PowerToolsTracing;
1111

1212
import static software.amazon.lambda.internal.LambdaHandlerProcessor.coldStartDone;
1313
import static software.amazon.lambda.internal.LambdaHandlerProcessor.isColdStart;
@@ -21,12 +21,12 @@ public final class LambdaTracingAspect {
2121
private static final ObjectMapper mapper = new ObjectMapper();
2222

2323
@Pointcut("@annotation(powerToolsTracing)")
24-
public void callAt(PowerToolTracing powerToolsTracing) {
24+
public void callAt(PowerToolsTracing powerToolsTracing) {
2525
}
2626

27-
@Around(value = "callAt(powerToolsTracing) && execution(@PowerToolTracing * *.*(..))", argNames = "pjp,powerToolsTracing")
27+
@Around(value = "callAt(powerToolsTracing) && execution(@PowerToolsTracing * *.*(..))", argNames = "pjp,powerToolsTracing")
2828
public Object around(ProceedingJoinPoint pjp,
29-
PowerToolTracing powerToolsTracing) throws Throwable {
29+
PowerToolsTracing powerToolsTracing) throws Throwable {
3030
Object[] proceedArgs = pjp.getArgs();
3131
Subsegment segment;
3232

@@ -58,7 +58,7 @@ public Object around(ProceedingJoinPoint pjp,
5858
}
5959
}
6060

61-
private String namespace(PowerToolTracing powerToolsTracing) {
61+
private String namespace(PowerToolsTracing powerToolsTracing) {
6262
return powerToolsTracing.namespace().isEmpty() ? serviceName() : powerToolsTracing.namespace();
6363
}
6464

src/test/java/software/amazon/lambda/handlers/PowerTracerToolEnabled.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
import com.amazonaws.services.lambda.runtime.Context;
44
import com.amazonaws.services.lambda.runtime.RequestHandler;
5-
import software.amazon.lambda.tracing.PowerToolTracing;
5+
import software.amazon.lambda.tracing.PowerToolsTracing;
66

77
public class PowerTracerToolEnabled implements RequestHandler<Object, Object> {
88

99
@Override
10-
@PowerToolTracing(namespace = "lambdaHandler")
10+
@PowerToolsTracing(namespace = "lambdaHandler")
1111
public Object handleRequest(Object input, Context context) {
1212
return null;
1313
}

src/test/java/software/amazon/lambda/handlers/PowerTracerToolEnabledForStream.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55

66
import com.amazonaws.services.lambda.runtime.Context;
77
import com.amazonaws.services.lambda.runtime.RequestStreamHandler;
8-
import software.amazon.lambda.tracing.PowerToolTracing;
8+
import software.amazon.lambda.tracing.PowerToolsTracing;
99

1010
public class PowerTracerToolEnabledForStream implements RequestStreamHandler {
1111

1212
@Override
13-
@PowerToolTracing(namespace = "streamHandler")
13+
@PowerToolsTracing(namespace = "streamHandler")
1414
public void handleRequest(InputStream input, OutputStream output, Context context) {
1515

1616
}

src/test/java/software/amazon/lambda/handlers/PowerTracerToolEnabledForStreamWithNoMetaData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55

66
import com.amazonaws.services.lambda.runtime.Context;
77
import com.amazonaws.services.lambda.runtime.RequestStreamHandler;
8-
import software.amazon.lambda.tracing.PowerToolTracing;
8+
import software.amazon.lambda.tracing.PowerToolsTracing;
99

1010
public class PowerTracerToolEnabledForStreamWithNoMetaData implements RequestStreamHandler {
1111

1212
@Override
13-
@PowerToolTracing(captureResponse = false, captureError = false)
13+
@PowerToolsTracing(captureResponse = false, captureError = false)
1414
public void handleRequest(InputStream input, OutputStream output, Context context) {
1515

1616
}

src/test/java/software/amazon/lambda/handlers/PowerTracerToolEnabledWithException.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
import com.amazonaws.services.lambda.runtime.Context;
44
import com.amazonaws.services.lambda.runtime.RequestHandler;
5-
import software.amazon.lambda.tracing.PowerToolTracing;
5+
import software.amazon.lambda.tracing.PowerToolsTracing;
66

77
public class PowerTracerToolEnabledWithException implements RequestHandler<Object, Object> {
88

99
@Override
10-
@PowerToolTracing(namespace = "lambdaHandler")
10+
@PowerToolsTracing(namespace = "lambdaHandler")
1111
public Object handleRequest(Object input, Context context) {
1212
throw new RuntimeException("I am failing!");
1313
}

src/test/java/software/amazon/lambda/handlers/PowerTracerToolEnabledWithNoMetaData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
import com.amazonaws.services.lambda.runtime.Context;
44
import com.amazonaws.services.lambda.runtime.RequestHandler;
5-
import software.amazon.lambda.tracing.PowerToolTracing;
5+
import software.amazon.lambda.tracing.PowerToolsTracing;
66

77
public class PowerTracerToolEnabledWithNoMetaData implements RequestHandler<Object, Object> {
88

99
@Override
10-
@PowerToolTracing(captureResponse = false, captureError = false)
10+
@PowerToolsTracing(captureResponse = false, captureError = false)
1111
public Object handleRequest(Object input, Context context) {
1212
return null;
1313
}

0 commit comments

Comments
 (0)