fixes for PR

Author: sthulb

.github/ISSUE_TEMPLATE/bug_report.md

@@ -65,17 +65,6 @@ body:
         - "provided.al2023"
     validations:
       required: true
-  - type: dropdown
-    id: packaging
-    attributes:
-      label: Packaging format used
-      options:
-        - Lambda Layers
-        - Serverless Application Repository (SAR) App
-        - PyPi
-      multiple: true
-    validations:
-      required: true
   - type: textarea
     id: logs
     attributes:

.github/actions/version/action.yml

@@ -13,6 +13,7 @@ description: |
     uses: .github/actions/version
     with:
       new_version: 1.20.0
+      snapshot: 'false'
   ```
 
 inputs:
@@ -44,7 +45,7 @@ runs:
       run: |
         mvn versions:set -DnewVersion=${{ inputs.new_version }} -DprocessAllModules=true -DallowSnapshots=true
 
-    - id: asset_veersion
+    - id: asset_version
       name: Replace version for assets
       if: ${{ inputs.snapshot == 'true' }}
       env:

.github/workflows/check-build.yml

@@ -3,8 +3,9 @@ on:
   pull_request:
     paths:
       - 'powertools-batch/**'
-      - 'powertools-cloudformation/**'
       - 'powertools-core/**'
+      - 'powertools-cloudformation/**'
+      - 'powertools-common/**'
       - 'powertools-e2e-tests/**'
       - 'powertools-idempotency/**'
       - 'powertools-large-messages/**'
@@ -13,7 +14,7 @@ on:
       - 'powertools-parameters/**'
       - 'powertools-serialization/**'
       - 'powertools-sqs/**'
-      - 'powertools-test-suite/**'
+      - 'powertools-tracing/**'
       - 'powertools-tracing/**'
       - 'powertools-validation/**'
       - 'examples/**'
@@ -23,10 +24,12 @@ on:
   push:
     branches:
       - main
-    paths:
+      - v2
+    paths: # add other modules when there are under e2e tests
       - 'powertools-batch/**'
-      - 'powertools-cloudformation/**'
       - 'powertools-core/**'
+      - 'powertools-cloudformation/**'
+      - 'powertools-common/**'
       - 'powertools-e2e-tests/**'
       - 'powertools-idempotency/**'
       - 'powertools-large-messages/**'
@@ -35,11 +38,11 @@ on:
       - 'powertools-parameters/**'
       - 'powertools-serialization/**'
       - 'powertools-sqs/**'
-      - 'powertools-test-suite/**'
+      - 'powertools-tracing/**'
       - 'powertools-tracing/**'
       - 'powertools-validation/**'
-      - 'examples/**'
       - 'pom.xml'
+      - 'examples/**'
       - 'examples/pom.xml'
       - '.github/workflows/**'
 
@@ -51,7 +54,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        java_version:
+        java:
           - 8
           - 11
           - 17
@@ -64,9 +67,10 @@ jobs:
         uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12
         with:
           distribution: corretto
-          java-version: ${{ matrix.java_version }}
+          java-version: ${{ matrix.java }}
           cache: maven
       - id: build-maven
         name: Build (Maven)
+        if: ${{ matrix.java != '8' }}
         run: |
           mvn -B install --file pom.xml

.github/workflows/check-e2e.yml

@@ -4,22 +4,27 @@ on:
   push:
       branches:
         - main
+        - v2
       paths: # add other modules when there are under e2e tests
-        - 'powertools-e2e-tests/**'
         - 'powertools-batch/**'
         - 'powertools-core/**'
+        - 'powertools-cloudformation/**'
         - 'powertools-common/**'
+        - 'powertools-e2e-tests/**'
         - 'powertools-idempotency/**'
-        - 'powertools-large-message/**'
+        - 'powertools-large-messages/**'
         - 'powertools-logging/**'
         - 'powertools-metrics/**'
         - 'powertools-parameters/**'
         - 'powertools-serialization/**'
+        - 'powertools-sqs/**'
+        - 'powertools-tracing/**'
         - 'powertools-tracing/**'
+        - 'powertools-validation/**'
         - 'pom.xml'
 
 name: E2E Tests
-run-name: 
+run-name: E2E Tests - ${{ github.event_name }}
 
 permissions:
   contents: read
@@ -32,9 +37,12 @@ jobs:
       id-token: write
     environment: E2E
     strategy:
-      max-parallel: 4
+      max-parallel: 3
       matrix:
-        java: [ 8, 11, 17, 21 ]
+        java:
+          - 11
+          - 17
+          - 21
     steps:
       - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9  # v3.5.3
       - name: Setup java

.github/workflows/check-spotbugs.yml

@@ -2,17 +2,23 @@ on:
   pull_request:
     branches:
       - main
+      - v2
     paths:
-      - 'powertools-cloudformation/**'
+      - 'powertools-batch/**'
       - 'powertools-core/**'
-      - 'powertools-serialization/**'
+      - 'powertools-cloudformation/**'
+      - 'powertools-common/**'
+      - 'powertools-e2e-tests/**'
+      - 'powertools-idempotency/**'
+      - 'powertools-large-messages/**'
       - 'powertools-logging/**'
+      - 'powertools-metrics/**'
+      - 'powertools-parameters/**'
+      - 'powertools-serialization/**'
       - 'powertools-sqs/**'
       - 'powertools-tracing/**'
+      - 'powertools-tracing/**'
       - 'powertools-validation/**'
-      - 'powertools-parameters/**'
-      - 'powertools-idempotency/**'
-      - 'powertools-metrics/**'
       - 'powertools-test-suite/**'
       - 'pom.xml'
       - '.github/workflows/**'

.github/workflows/release.yml

@@ -8,6 +8,10 @@ on:
         type: boolean
         description: Create snapshot release
         default: true
+      is_v2_build:
+        type: boolean
+        description: Create a v2 build
+        default: false
       skip_checks: 
         type: boolean
         description: Skip quality checks
@@ -16,9 +20,9 @@ on:
         type: boolean
         description: Ship publish to Maven Central
         default: false
-      conintue_on_error: 
+      continue_on_error: 
         type: boolean
-        description: 
+        description: Continue to build if there's an error in quality checks
         default: false
 
 name: Release
@@ -32,7 +36,7 @@ env:
   RELEASE_TAG_VERSION: ${{ inputs.version }}
 
 jobs:
-  process_version:
+  setup:
     runs-on: ubuntu-latest
     outputs:
       version: ${{ format('{0}{1}', steps.version_release.outputs.version, steps.version_snapshot.outputs.version) }}
@@ -47,11 +51,21 @@ jobs:
         name: Version
         run: |
           echo version="${{ inputs.version }}" >> "$GITHUB_OUTPUT"
+      - id: build_matrix_v1
+        name: Build matrix (v1)
+        if: ${{ inputs.is_v2_build == false }}
+        run: |
+          echo build_matrix='["8", "11", "17", "21"]' >> "$GITHUB_OUTPUT"
+      - id: build_matrix_v2
+        name: Build matrix (v2)
+        if: ${{ inputs.is_v2_build == true }} 
+        run: |
+          echo build_matrix='["11", "17", "21"]'>> "$GITHUB_OUTPUT"
 
   version_seal:
     runs-on: ubuntu-latest
     needs:
-      - process_version
+      - setup
     outputs:
       source_hash: ${{ steps.upload_source.outputs.artifact-digest }}
     steps:
@@ -62,7 +76,7 @@ jobs:
         name: version
         uses: ./.github/actions/version
         with:
-          new_version: ${{ needs.process_version.outputs.version }}
+          new_version: ${{ needs.setup.outputs.version }}
           snapshot: ${{ inputs.snapshot}}
       - id: upload_source
         name: Upload artifacts
@@ -98,10 +112,10 @@ jobs:
       # non-exhuastive, but gives a fair indication if the final build will succeed, tests will run when we build later
       - name: Run unit tests
         run: mvn -B test --file pom.xml
-        continue-on-error: ${{ inputs.conintue_on_error }}
+        continue-on-error: ${{ inputs.continue_on_error }}
       - name: Run Spotbugs
-        run: mvn -Pbuild-with-spotbugs -B install --file pom.xml -DskipTests -Dmaven.javadoc.skip=true -Dspotbugs.failOnError=${{ !inputs.conintue_on_error }} 
-        continue-on-error: ${{ inputs.conintue_on_error }}
+        run: mvn -Pbuild-with-spotbugs -B install --file pom.xml -DskipTests -Dmaven.javadoc.skip=true -Dspotbugs.failOnError=${{ !inputs.continue_on_error }} 
+        continue-on-error: ${{ inputs.continue_on_error }}
       - uses: pmd/pmd-github-action@d9c1f3c5940cbf5923f1354e83fa858b4496ebaa # v2.0.0
         with:
           rulesets: '.github/pmd-ruleset.xml'
@@ -111,15 +125,12 @@ jobs:
   build:
     runs-on: ubuntu-latest
     needs:
+      - setup
       - quality
       - version_seal
     strategy:
       matrix:
-        java_version:
-          - 8
-          - 11
-          - 17
-          - 21
+        java: ${{ fromJson(needs.setup.outputs.build_matrix) }}
     steps:
       - id: download_source
         name: Download artifacts
@@ -130,7 +141,7 @@ jobs:
         uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12
         with:
           distribution: corretto
-          java-version: ${{ matrix.java_version }}
+          java-version: ${{ matrix.java }}
           cache: maven
       - id: build-maven
         name: Build (Maven)

.github/workflows/security-branch-protections.yml

@@ -22,7 +22,7 @@ jobs:
     permissions:
       contents: write
     environment: Security
-    if: github.repository == 'aws-powertools/powertools-lambda-java'
+    if: ${{ github.repository == 'aws-powertools/powertools-lambda-java' }}
     strategy:
       matrix:
         # List of branches we want to monitor for protection changes