Fix PMD findings.

Author: phipag

powertools-parameters/powertools-parameters-dynamodb/src/test/java/software/amazon/lambda/powertools/parameters/dynamodb/DynamoDbProviderE2ETest.java

@@ -38,8 +38,8 @@
 @Disabled
 class DynamoDbProviderE2ETest {
 
-    final String ParamsTestTable = "ddb-params-test";
-    final String MultiparamsTestTable = "ddb-multiparams-test";
+    private static final String PARAMS_TEST_TABLE = "ddb-params-test";
+    private static final String MULTI_PARAMS_TEST_TABLE = "ddb-multiparams-test";
     private final DynamoDbClient ddbClient;
 
     public DynamoDbProviderE2ETest() {
@@ -55,16 +55,16 @@ public DynamoDbProviderE2ETest() {
     void TestGetValue() {
 
         // Arrange
-        HashMap<String, AttributeValue> testItem = new HashMap<String, AttributeValue>();
+        Map<String, AttributeValue> testItem = new HashMap<>();
         testItem.put("id", AttributeValue.fromS("test_param"));
         testItem.put("value", AttributeValue.fromS("the_value_is_hello!"));
         ddbClient.putItem(PutItemRequest.builder()
-                .tableName(ParamsTestTable)
+                .tableName(PARAMS_TEST_TABLE)
                 .item(testItem)
                 .build());
 
         // Act
-        DynamoDbProvider provider = makeProvider(ParamsTestTable);
+        DynamoDbProvider provider = makeProvider(PARAMS_TEST_TABLE);
         String value = provider.getValue("test_param");
 
         // Assert
@@ -75,26 +75,26 @@ void TestGetValue() {
     void TestGetValues() {
 
         // Arrange
-        HashMap<String, AttributeValue> testItem = new HashMap<String, AttributeValue>();
+        Map<String, AttributeValue> testItem = new HashMap<>();
         testItem.put("id", AttributeValue.fromS("test_param"));
         testItem.put("sk", AttributeValue.fromS("test_param_part_1"));
         testItem.put("value", AttributeValue.fromS("the_value_is_hello!"));
         ddbClient.putItem(PutItemRequest.builder()
-                .tableName(MultiparamsTestTable)
+                .tableName(MULTI_PARAMS_TEST_TABLE)
                 .item(testItem)
                 .build());
 
-        HashMap<String, AttributeValue> testItem2 = new HashMap<String, AttributeValue>();
+        Map<String, AttributeValue> testItem2 = new HashMap<>();
         testItem2.put("id", AttributeValue.fromS("test_param"));
         testItem2.put("sk", AttributeValue.fromS("test_param_part_2"));
         testItem2.put("value", AttributeValue.fromS("the_value_is_still_hello!"));
         ddbClient.putItem(PutItemRequest.builder()
-                .tableName(MultiparamsTestTable)
+                .tableName(MULTI_PARAMS_TEST_TABLE)
                 .item(testItem2)
                 .build());
 
         // Act
-        DynamoDbProvider provider = makeProvider(MultiparamsTestTable);
+        DynamoDbProvider provider = makeProvider(MULTI_PARAMS_TEST_TABLE);
         Map<String, String> values = provider.getMultipleValues("test_param");
 
         // Assert

powertools-parameters/powertools-parameters-dynamodb/src/test/java/software/amazon/lambda/powertools/parameters/dynamodb/DynamoDbProviderTest.java

@@ -47,7 +47,7 @@
 @ExtendWith(MockitoExtension.class)
 class DynamoDbProviderTest {
 
-    private final String tableName = "ddb-test-table";
+    private static final String TABLE_NAME = "ddb-test-table";
 
     @Mock
     DynamoDbClient client;
@@ -67,7 +67,7 @@ class DynamoDbProviderTest {
     void init() {
         openMocks(this);
         CacheManager cacheManager = new CacheManager();
-        provider = new DynamoDbProvider(cacheManager, transformationManager, client, tableName);
+        provider = new DynamoDbProvider(cacheManager, transformationManager, client, TABLE_NAME);
     }
 
     @Test
@@ -76,7 +76,7 @@ void getValue() {
         // Arrange
         String key = "Key1";
         String expectedValue = "Value1";
-        HashMap<String, AttributeValue> responseData = new HashMap<String, AttributeValue>();
+        Map<String, AttributeValue> responseData = new HashMap<>();
         responseData.put("id", AttributeValue.fromS(key));
         responseData.put("value", AttributeValue.fromS(expectedValue));
         GetItemResponse response = GetItemResponse.builder()
@@ -89,7 +89,7 @@ void getValue() {
 
         // Assert
         assertThat(value).isEqualTo(expectedValue);
-        assertThat(getItemValueCaptor.getValue().tableName()).isEqualTo(tableName);
+        assertThat(getItemValueCaptor.getValue().tableName()).isEqualTo(TABLE_NAME);
         assertThat(getItemValueCaptor.getValue().key().get("id").s()).isEqualTo(key);
     }
 
@@ -166,7 +166,7 @@ void getValues() {
         assertThat(values.size()).isEqualTo(2);
         assertThat(values.get(subkey1)).isEqualTo(val1);
         assertThat(values.get(subkey2)).isEqualTo(val2);
-        assertThat(queryRequestCaptor.getValue().tableName()).isEqualTo(tableName);
+        assertThat(queryRequestCaptor.getValue().tableName()).isEqualTo(TABLE_NAME);
         assertThat(queryRequestCaptor.getValue().keyConditionExpression()).isEqualTo("id = :v_id");
         assertThat(queryRequestCaptor.getValue().expressionAttributeValues().get(":v_id").s()).isEqualTo(key);
     }