Fixed Sonar issues

Author: subhash686

powertools-common/src/main/java/software/amazon/lambda/powertools/common/internal/ClassPreLoader.java

@@ -28,6 +28,9 @@
 public class ClassPreLoader {
     public static final String CLASSES_FILE = "classesloaded.txt";
 
+    private ClassPreLoader() {
+        // Hide default constructor
+    }
     /**
      * Initializes the classes listed in the classesloaded resource
      */

powertools-common/src/test/java/software/amazon/lambda/powertools/common/internal/ClassPreLoaderTest.java

@@ -1,53 +1,14 @@
 package software.amazon.lambda.powertools.common.internal;
 
-import static org.mockito.Mockito.*;
-
-import java.io.ByteArrayInputStream;
-import java.io.InputStream;
-import java.net.URL;
-import java.net.URLConnection;
-import java.util.Collections;
+import static org.junit.jupiter.api.Assertions.*;
 
 import org.junit.jupiter.api.Test;
 
 class ClassPreLoaderTest {
 
     @Test
-    void preloadClasses_shouldIgnoreInvalidClassesAndLoadValidClasses() throws Exception {
-        // Mock the class loader with no resources
-        ClassLoader classLoader = mock(ClassLoader.class);
-        URL mockUrl = mock(URL.class);
-        URLConnection mockConnection = mock(URLConnection.class);
-        InputStream mockInputStream = new ByteArrayInputStream("java.lang.String\nInvalid.Class".getBytes());
-
-        when(mockUrl.openConnection()).thenReturn(mockConnection);
-        when(mockConnection.getInputStream()).thenReturn(mockInputStream);
-        when(classLoader.getResources(ClassPreLoader.CLASSES_FILE))
-                .thenReturn(Collections.enumeration(Collections.singletonList(mockUrl)));
-
-        // Inject the mocked class loader
-        Thread.currentThread().setContextClassLoader(classLoader);
-        // Call the method under test
-        ClassPreLoader.preloadClasses();
-
-        // Verify that only the valid class was loaded
-        Class.forName("java.lang.String", true, ClassPreLoader.class.getClassLoader());
-    }
-
-    @Test
-    void preloadClasses_shouldHandleEmptyResources() throws Exception {
-        // Mock the class loader with no resources
-        ClassLoader classLoader = mock(ClassLoader.class);
-        when(classLoader.getResources(ClassPreLoader.CLASSES_FILE))
-                .thenReturn(Collections.emptyEnumeration());
-
-        // Inject the mocked class loader
-        Thread.currentThread().setContextClassLoader(classLoader);
-
-        // Call the method under test
-        ClassPreLoader.preloadClasses();
-
-        // Verify no interactions with the class loader
-        verifyNoInteractions(classLoader);
+    void preloadClasses_shouldIgnoreInvalidClassesAndLoadValidClasses() {
+        // Verify that the missing class did not throw any exception
+        assertDoesNotThrow(ClassPreLoader::preloadClasses);
     }
 }

powertools-common/src/test/resources/classesloaded.txt

@@ -0,0 +1 @@
+software.amazon.lambda.powertools.common.internal.NonExistingClass

powertools-idempotency/powertools-idempotency-core/src/main/java/software/amazon/lambda/powertools/idempotency/internal/IdempotencyHandler.java

@@ -83,6 +83,7 @@ public void beforeCheckpoint(org.crac.Context<? extends Resource> context) throw
 
     @Override
     public void afterRestore(org.crac.Context<? extends Resource> context) throws Exception {
+        // This is a no-op, as we don't need to do anything after restore
     }
 
     /**

powertools-metrics/src/main/java/software/amazon/lambda/powertools/metrics/internal/LambdaMetricsAspect.java

@@ -155,5 +155,6 @@ public void beforeCheckpoint(org.crac.Context<? extends Resource> context) throw
 
     @Override
     public void afterRestore(org.crac.Context<? extends Resource> context) throws Exception {
+        // No action needed after restore
     }
 }