java 1.8 AL1 is deprecated (#1692)

jeromevdl · web-flow · commit b64dd49cbfcc · 2024-08-02T14:49:46.000+02:00
diff --git a/powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/testutils/Infrastructure.java b/powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/testutils/Infrastructure.java
@@ -513,7 +513,7 @@ private Builder() {
 
         private JavaRuntime mapRuntimeVersion(String environmentVariableName) {
             String javaVersion = System.getenv(environmentVariableName); // must be set in GitHub actions
-            JavaRuntime ret = null;
+            JavaRuntime ret;
             if (javaVersion == null) {
                 throw new IllegalArgumentException(environmentVariableName + " is not set");
             }
diff --git a/powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/testutils/JavaRuntime.java b/powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/testutils/JavaRuntime.java
@@ -17,7 +17,6 @@
 import software.amazon.awscdk.services.lambda.Runtime;
 
 public enum JavaRuntime {
-    JAVA8("java8", Runtime.JAVA_8, "1.8"),
     JAVA8AL2("java8.al2", Runtime.JAVA_8_CORRETTO, "1.8"),
     JAVA11("java11", Runtime.JAVA_11, "11"),
     JAVA17("java17", Runtime.JAVA_17, "17"),

Original file line number	Diff line number	Diff line change
`@@ -513,7 +513,7 @@ private Builder() {`
`513`	`513`
`514`	`514`	`private JavaRuntime mapRuntimeVersion(String environmentVariableName) {`
`515`	`515`	`String javaVersion = System.getenv(environmentVariableName); // must be set in GitHub actions`
`516`		`- JavaRuntime ret = null;`
	`516`	`+ JavaRuntime ret;`
`517`	`517`	`if (javaVersion == null) {`
`518`	`518`	`throw new IllegalArgumentException(environmentVariableName + " is not set");`
`519`	`519`	`}`