Fix more pmd_analyze issues.

Author: phipag

powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/TracingE2ET.java

@@ -110,7 +110,7 @@ void test_tracing() {
         assertThat(sub.getName()).isIn("## internal_stuff", "## buildMessage");
 
         SubSegment buildMessage = handleRequestSegment.getSubsegments().stream()
-                .filter(subSegment -> subSegment.getName().equals("## buildMessage"))
+                .filter(subSegment -> "## buildMessage".equals(subSegment.getName()))
                 .findFirst().orElse(null);
         assertThat(buildMessage).isNotNull();
         assertThat(buildMessage.getAnnotations()).hasSize(1);

powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/testutils/metrics/MetricsFetcher.java

@@ -17,6 +17,7 @@
 import java.time.Instant;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.function.Supplier;
 
@@ -76,7 +77,7 @@ public List<Double> fetchMetrics(Instant start, Instant end, int period, String
                     .startTime(start)
                     .endTime(end)
                     .metricDataQueries(MetricDataQuery.builder()
-                            .id(metricName.toLowerCase())
+                            .id(metricName.toLowerCase(Locale.ROOT))
                             .metricStat(MetricStat.builder()
                                     .unit(StandardUnit.COUNT)
                                     .metric(Metric.builder()