Skip to content

Commit e1dcfa6

Browse files
Minor static analysis code fixes (#37)
1 parent aeb8e48 commit e1dcfa6

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

src/main/java/org/apache/logging/log4j/core/layout/LambdaJsonLayout.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public class LambdaJsonLayout extends AbstractJacksonLayout {
3939

4040
static final String CONTENT_TYPE = "application/json";
4141

42-
private ObjectMapper objectMapper;
42+
private final ObjectMapper objectMapper;
4343

4444
public static class Builder<B extends Builder<B>> extends AbstractJacksonLayout.Builder<B>
4545
implements org.apache.logging.log4j.core.util.Builder<LambdaJsonLayout> {

src/main/java/software/amazon/lambda/logging/internal/DefaultLambdaFields.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ enum DefaultLambdaFields {
1111
FUNCTION_ARN("functionArn"),
1212
FUNCTION_MEMORY_SIZE("functionMemorySize");
1313

14-
private String name;
14+
private final String name;
1515

1616
DefaultLambdaFields(String name) {
1717
this.name = name;

src/main/java/software/amazon/lambda/logging/internal/LambdaLoggingAspect.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
public final class LambdaLoggingAspect {
3535
private static final ObjectMapper mapper = new ObjectMapper();
3636

37+
@SuppressWarnings({"EmptyMethod", "unused"})
3738
@Pointcut("@annotation(powerToolsLogging)")
3839
public void callAt(PowerToolsLogging powerToolsLogging) {
3940
}

src/main/java/software/amazon/lambda/tracing/internal/LambdaTracingAspect.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import com.amazonaws.xray.AWSXRay;
44
import com.amazonaws.xray.entities.Subsegment;
5-
import com.fasterxml.jackson.databind.ObjectMapper;
65
import org.aspectj.lang.ProceedingJoinPoint;
76
import org.aspectj.lang.annotation.Around;
87
import org.aspectj.lang.annotation.Aspect;
@@ -18,8 +17,8 @@
1817

1918
@Aspect
2019
public final class LambdaTracingAspect {
21-
private static final ObjectMapper mapper = new ObjectMapper();
2220

21+
@SuppressWarnings({"EmptyMethod", "unused"})
2322
@Pointcut("@annotation(powerToolsTracing)")
2423
public void callAt(PowerToolsTracing powerToolsTracing) {
2524
}

src/test/java/software/amazon/lambda/handlers/PowerLogToolEnabled.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ public Object handleRequest(Object input, Context context) {
1414

1515
@PowerToolsLogging
1616
public void anotherMethod() {
17-
17+
System.out.println("test");
1818
}
1919
}

0 commit comments

Comments
 (0)