Skip to content

Commit fb3dcc0

Browse files
committed
Rename to Log4jConstants.
1 parent dd8473d commit fb3dcc0

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

powertools-logging/powertools-logging-log4j/src/main/java/software/amazon/lambda/powertools/logging/log4j/BufferingAppender.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package software.amazon.lambda.powertools.logging.log4j;
1616

17+
import static software.amazon.lambda.powertools.logging.log4j.Log4jConstants.BUFFERING_APPENDER_PLUGIN_NAME;
18+
1719
import java.io.Serializable;
1820
import java.util.Deque;
1921

@@ -37,8 +39,6 @@
3739
import software.amazon.lambda.powertools.logging.internal.BufferManager;
3840
import software.amazon.lambda.powertools.logging.internal.KeyBuffer;
3941

40-
import static software.amazon.lambda.powertools.logging.log4j.BufferingAppenderConstants.NAME;
41-
4242
/**
4343
* A Log4j2 appender that buffers log events by AWS X-Ray trace ID for optimized Lambda logging.
4444
*
@@ -82,7 +82,7 @@
8282
*
8383
* @see software.amazon.lambda.powertools.logging.PowertoolsLogging#flushLogBuffer()
8484
*/
85-
@Plugin(name = NAME, category = Core.CATEGORY_NAME, elementType = Appender.ELEMENT_TYPE)
85+
@Plugin(name = BUFFERING_APPENDER_PLUGIN_NAME, category = Core.CATEGORY_NAME, elementType = Appender.ELEMENT_TYPE)
8686
public class BufferingAppender extends AbstractAppender implements BufferManager {
8787

8888
private final AppenderRef[] appenderRefs;
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@
1515
package software.amazon.lambda.powertools.logging.log4j;
1616

1717
/**
18-
* Constants for BufferingAppender configuration and references.
18+
* Constants for Log4j2 configuration and references.
1919
*/
20-
public final class BufferingAppenderConstants {
20+
public final class Log4jConstants {
2121

2222
/**
23-
* The name used for BufferingAppender in Log4j2 configuration and references.
23+
* The plugin name for BufferingAppender in Log4j2 configuration.
2424
*/
25-
public static final String NAME = "BufferingAppender";
25+
public static final String BUFFERING_APPENDER_PLUGIN_NAME = "BufferingAppender";
2626

27-
private BufferingAppenderConstants() {
27+
private Log4jConstants() {
2828
// Utility class
2929
}
30-
}
30+
}

powertools-logging/powertools-logging-log4j/src/main/java/software/amazon/lambda/powertools/logging/log4j/internal/Log4jLoggingManager.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package software.amazon.lambda.powertools.logging.log4j.internal;
1616

17+
import static software.amazon.lambda.powertools.logging.log4j.Log4jConstants.BUFFERING_APPENDER_PLUGIN_NAME;
18+
1719
import org.apache.logging.log4j.Level;
1820
import org.apache.logging.log4j.LogManager;
1921
import org.apache.logging.log4j.core.LoggerContext;
@@ -24,8 +26,6 @@
2426
import software.amazon.lambda.powertools.logging.internal.LoggingManager;
2527
import software.amazon.lambda.powertools.logging.log4j.BufferingAppender;
2628

27-
import static software.amazon.lambda.powertools.logging.log4j.BufferingAppenderConstants.NAME;
28-
2929
/**
3030
* LoggingManager for Log4j2 that provides log level management and buffer operations.
3131
* Implements both {@link LoggingManager} and {@link BufferManager} interfaces.
@@ -59,7 +59,7 @@ public org.slf4j.event.Level getLogLevel(Logger logger) {
5959
public void flushBuffer() {
6060
LoggerContext ctx = (LoggerContext) LogManager.getContext(false);
6161
BufferingAppender bufferingAppender = (BufferingAppender) ctx.getConfiguration()
62-
.getAppender(NAME);
62+
.getAppender(BUFFERING_APPENDER_PLUGIN_NAME);
6363
if (bufferingAppender != null) {
6464
bufferingAppender.flushBuffer();
6565
}
@@ -72,7 +72,7 @@ public void flushBuffer() {
7272
public void clearBuffer() {
7373
LoggerContext ctx = (LoggerContext) LogManager.getContext(false);
7474
BufferingAppender bufferingAppender = (BufferingAppender) ctx.getConfiguration()
75-
.getAppender(NAME);
75+
.getAppender(BUFFERING_APPENDER_PLUGIN_NAME);
7676
if (bufferingAppender != null) {
7777
bufferingAppender.clearBuffer();
7878
}

powertools-logging/powertools-logging-log4j/src/test/java/software/amazon/lambda/powertools/logging/log4j/BufferingAppenderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,6 @@ void shouldClearBufferManually() {
112112

113113
private BufferingAppender getBufferingAppender() {
114114
return (BufferingAppender) ((org.apache.logging.log4j.core.LoggerContext) LogManager.getContext(false))
115-
.getConfiguration().getAppender(BufferingAppenderConstants.NAME);
115+
.getConfiguration().getAppender(Log4jConstants.BUFFERING_APPENDER_PLUGIN_NAME);
116116
}
117117
}

0 commit comments

Comments
 (0)