Skip to content

Commit ffebe8c

Browse files
committed
Fix Spotbug issues.
1 parent 3c76357 commit ffebe8c

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

powertools-kafka/src/main/java/software/amazon/lambda/powertools/kafka/serializers/AbstractKafkaDeserializer.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import java.io.InputStream;
1717
import java.lang.reflect.ParameterizedType;
1818
import java.lang.reflect.Type;
19+
import java.nio.charset.StandardCharsets;
1920
import java.util.ArrayList;
2021
import java.util.Base64;
2122
import java.util.HashMap;
@@ -263,11 +264,11 @@ private <T> T deserialize(byte[] data, Class<T> type) throws IOException {
263264
private <T> T deserializePrimitive(byte[] data, Class<T> type) {
264265
// Handle String type
265266
if (type == String.class) {
266-
return (T) new String(data);
267+
return (T) new String(data, StandardCharsets.UTF_8);
267268
}
268269

269270
// Handle primitive types and their wrappers
270-
String str = new String(data);
271+
String str = new String(data, StandardCharsets.UTF_8);
271272

272273
if (type == Integer.class || type == int.class) {
273274
return (T) Integer.valueOf(str);

powertools-kafka/src/main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaJsonDeserializer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
package software.amazon.lambda.powertools.kafka.serializers;
1414

1515
import java.io.IOException;
16+
import java.nio.charset.StandardCharsets;
1617

1718
/**
1819
* Deserializer for Kafka records using JSON format.
@@ -21,7 +22,7 @@ public class KafkaJsonDeserializer extends AbstractKafkaDeserializer {
2122

2223
@Override
2324
protected <T> T deserializeObject(byte[] data, Class<T> type) throws IOException {
24-
String decodedStr = new String(data);
25+
String decodedStr = new String(data, StandardCharsets.UTF_8);
2526

2627
return objectMapper.readValue(decodedStr, type);
2728
}

powertools-kafka/src/main/java/software/amazon/lambda/powertools/kafka/serializers/LambdaDefaultDeserializer.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import java.io.IOException;
1616
import java.io.InputStream;
1717
import java.lang.reflect.Type;
18+
import java.nio.charset.StandardCharsets;
1819

1920
import com.amazonaws.services.lambda.runtime.serialization.factories.JacksonFactory;
2021

@@ -37,7 +38,7 @@ public <T> T fromJson(InputStream input, Type type) {
3738
// If the target type is String, read the input stream as a String
3839
if (type.equals(String.class)) {
3940
try {
40-
return (T) new String(input.readAllBytes());
41+
return (T) new String(input.readAllBytes(), StandardCharsets.UTF_8);
4142
} catch (IOException e) {
4243
throw new RuntimeException("Failed to read input stream as String", e);
4344
}
@@ -56,7 +57,7 @@ public <T> T fromJson(String input, Type type) {
5657

5758
// If the target type is InputStream, read the input stream as a String
5859
if (type.equals(InputStream.class)) {
59-
return (T) new String(input).getBytes();
60+
return (T) input.getBytes(StandardCharsets.UTF_8);
6061
}
6162

6263
return (T) JacksonFactory.getInstance().getSerializer(type).fromJson(input);

0 commit comments

Comments
 (0)