|
| 1 | +"""Comprehensive tests for UploadFile OpenAPI schema generation and validation coverage.""" |
| 2 | + |
| 3 | +import pytest |
| 4 | +from typing_extensions import Annotated |
| 5 | +from unittest.mock import Mock |
| 6 | + |
| 7 | +from aws_lambda_powertools.event_handler import APIGatewayRestResolver |
| 8 | +from aws_lambda_powertools.event_handler.openapi.params import File, UploadFile, fix_upload_file_schema_references |
| 9 | +from aws_lambda_powertools.event_handler.middlewares.openapi_validation import ( |
| 10 | + _get_field_value, _resolve_field_type, _convert_value_type |
| 11 | +) |
| 12 | +from typing import Union, Optional |
| 13 | + |
| 14 | + |
| 15 | +class TestUploadFileComprehensiveCoverage: |
| 16 | + """Comprehensive tests for UploadFile functionality covering missing lines.""" |
| 17 | + |
| 18 | + def test_upload_file_openapi_schema_generation(self): |
| 19 | + """Test UploadFile generates correct OpenAPI schema.""" |
| 20 | + app = APIGatewayRestResolver() |
| 21 | + |
| 22 | + @app.post("/upload") |
| 23 | + def upload_file(file: Annotated[UploadFile, File()]): |
| 24 | + return {"filename": file.filename} |
| 25 | + |
| 26 | + schema = app.get_openapi_schema() |
| 27 | + # Access the schema through object attributes |
| 28 | + upload_path = schema.paths["/upload"] |
| 29 | + request_body = upload_path.post.requestBody |
| 30 | + multipart_content = request_body.content["multipart/form-data"] |
| 31 | + |
| 32 | + assert multipart_content.schema_ is not None |
| 33 | + |
| 34 | + def test_upload_file_schema_fix_resolves_references(self): |
| 35 | + """Test schema fix function resolves UploadFile component references.""" |
| 36 | + app = APIGatewayRestResolver() |
| 37 | + |
| 38 | + @app.post("/upload") |
| 39 | + def upload_file(file: Annotated[UploadFile, File()]): |
| 40 | + return {"status": "ok"} |
| 41 | + |
| 42 | + schema = app.get_openapi_schema() |
| 43 | + # Convert to dict for processing by fix function |
| 44 | + schema_dict = schema.model_dump() |
| 45 | + fix_upload_file_schema_references(schema_dict) |
| 46 | + |
| 47 | + # Verify components exist and are processed |
| 48 | + assert "components" in schema_dict |
| 49 | + |
| 50 | + def test_upload_file_validation_methods(self): |
| 51 | + """Test UploadFile validation methods for coverage.""" |
| 52 | + upload_file = UploadFile(file=b"test content", filename="test.txt") |
| 53 | + |
| 54 | + # Test __get_validators__ method |
| 55 | + validators = upload_file.__get_validators__() |
| 56 | + assert callable(next(validators)) |
| 57 | + |
| 58 | + # Test _validate_with_info method - this covers lines in validation |
| 59 | + validation_info = Mock() |
| 60 | + validated = upload_file._validate_with_info(b"content", validation_info) |
| 61 | + assert isinstance(validated, UploadFile) |
| 62 | + |
| 63 | + def test_upload_file_pydantic_schema_methods(self): |
| 64 | + """Test UploadFile Pydantic schema generation methods.""" |
| 65 | + # Test __get_pydantic_json_schema__ - expect description to be included |
| 66 | + json_schema = UploadFile.__get_pydantic_json_schema__(Mock(), Mock()) |
| 67 | + expected_schema = { |
| 68 | + "type": "string", |
| 69 | + "format": "binary", |
| 70 | + "description": "A file uploaded as part of a multipart/form-data request" |
| 71 | + } |
| 72 | + assert json_schema == expected_schema |
| 73 | + |
| 74 | + # Test __modify_schema__ |
| 75 | + field_schema = {"type": "object"} |
| 76 | + UploadFile.__modify_schema__(field_schema) |
| 77 | + assert field_schema["type"] == "string" |
| 78 | + assert field_schema["format"] == "binary" |
| 79 | + |
| 80 | + def test_validation_middleware_functions(self): |
| 81 | + """Test validation middleware functions for coverage.""" |
| 82 | + # Test _get_field_value with various scenarios |
| 83 | + mock_field = Mock() |
| 84 | + mock_field.alias = "test_field" |
| 85 | + assert _get_field_value({"test_field": "value"}, mock_field) == "value" |
| 86 | + assert _get_field_value(None, mock_field) is None |
| 87 | + |
| 88 | + # Test field without alias (AttributeError path) |
| 89 | + mock_field_no_alias = Mock(spec=[]) # No alias attribute |
| 90 | + assert _get_field_value({"test": "value"}, mock_field_no_alias) is None |
| 91 | + |
| 92 | + # Test _resolve_field_type with different Union scenarios |
| 93 | + assert _resolve_field_type(Union[str, None]) == str |
| 94 | + assert _resolve_field_type(Optional[int]) == int |
| 95 | + assert _resolve_field_type(str) == str |
| 96 | + |
| 97 | + # Test _convert_value_type for UploadFile conversion |
| 98 | + upload_file = _convert_value_type(b"content", UploadFile) |
| 99 | + assert isinstance(upload_file, UploadFile) |
| 100 | + assert _convert_value_type("string", str) == "string" |
| 101 | + |
| 102 | + def test_schema_fix_edge_cases(self): |
| 103 | + """Test schema fix function edge cases.""" |
| 104 | + # Test with empty schema |
| 105 | + empty_schema = {} |
| 106 | + fix_upload_file_schema_references(empty_schema) |
| 107 | + assert empty_schema == {} |
| 108 | + |
| 109 | + # Test with schema missing components |
| 110 | + schema_no_components = {"paths": {}} |
| 111 | + fix_upload_file_schema_references(schema_no_components) |
| 112 | + # Should not crash and may or may not add components |
| 113 | + |
| 114 | + def test_upload_file_multipart_handling(self): |
| 115 | + """Test UploadFile in multipart scenarios for additional coverage.""" |
| 116 | + app = APIGatewayRestResolver() |
| 117 | + |
| 118 | + @app.post("/upload-multi") |
| 119 | + def upload_multiple( |
| 120 | + primary: Annotated[UploadFile, File()], |
| 121 | + secondary: Annotated[bytes, File()] |
| 122 | + ): |
| 123 | + return {"files": 2} |
| 124 | + |
| 125 | + schema = app.get_openapi_schema() |
| 126 | + schema_dict = schema.model_dump() |
| 127 | + fix_upload_file_schema_references(schema_dict) |
| 128 | + |
| 129 | + # Verify multipart handling works without errors |
| 130 | + assert schema_dict is not None |
0 commit comments