Skip to content

Commit 3ff8a01

Browse files
committed
fix: correct in_subsegment assertion
1 parent 4e7236d commit 3ff8a01

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

tests/unit/test_tracing.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -179,10 +179,9 @@ def test_tracer_no_autopatch(patch_mock):
179179
assert patch_mock.call_count == 0
180180

181181

182-
def test_tracer_lambda_handler_does_not_add_empty_response_as_metadata(mocker, provider_stub):
182+
def test_tracer_lambda_handler_does_not_add_empty_response_as_metadata(mocker, provider_stub, in_subsegment_mock):
183183
# GIVEN tracer is initialized
184-
put_metadata_mock = mocker.MagicMock()
185-
provider = provider_stub(put_metadata_mock=put_metadata_mock)
184+
provider = provider_stub(in_subsegment=in_subsegment_mock.in_subsegment)
186185
tracer = Tracer(provider=provider)
187186

188187
# WHEN capture_lambda_handler decorator is used
@@ -194,13 +193,12 @@ def handler(event, context):
194193
handler({}, mocker.MagicMock())
195194

196195
# THEN we should not add empty metadata
197-
assert put_metadata_mock.call_count == 0
196+
assert in_subsegment_mock.put_metadata.call_count == 0
198197

199198

200-
def test_tracer_method_does_not_add_empty_response_as_metadata(mocker, provider_stub):
199+
def test_tracer_method_does_not_add_empty_response_as_metadata(mocker, provider_stub, in_subsegment_mock):
201200
# GIVEN tracer is initialized
202-
put_metadata_mock = mocker.MagicMock()
203-
provider = provider_stub(put_metadata_mock=put_metadata_mock)
201+
provider = provider_stub(in_subsegment=in_subsegment_mock.in_subsegment)
204202
tracer = Tracer(provider=provider)
205203

206204
# WHEN capture_method decorator is used
@@ -212,7 +210,7 @@ def greeting(name, message):
212210
greeting(name="Foo", message="Bar")
213211

214212
# THEN we should not add empty metadata
215-
assert put_metadata_mock.call_count == 0
213+
assert in_subsegment_mock.put_metadata.call_count == 0
216214

217215

218216
@mock.patch("aws_lambda_powertools.tracing.tracer.aws_xray_sdk.core.patch")

0 commit comments

Comments
 (0)