Addressed the feedbacks

Author: sdangol

packages/event-handler/src/rest/middleware/compress.ts

@@ -75,10 +75,10 @@ const compress = (options?: CompressionOptions): Middleware => {
     // Check if response should be compressed
     if (
       isEncodedOrChunked ||
-      reqCtx.request.method === 'HEAD' || // HEAD request
-      (contentLength && Number(contentLength) < threshold) || // content-length below threshold
-      !shouldCompress(reqCtx.res) || // not compressible type
-      !shouldTransform(reqCtx.res) || // cache-control: no-transform
+      reqCtx.request.method === 'HEAD' ||
+      (contentLength && Number(contentLength) < threshold) ||
+      !shouldCompress(reqCtx.res) ||
+      !shouldTransform(reqCtx.res) ||
       !reqCtx.res.body
     ) {
       return;

packages/event-handler/tests/unit/rest/helpers.ts

@@ -70,10 +70,10 @@ export const createNoNextMiddleware = (
 export const createSettingHeadersMiddleware = (headers: {
   [key: string]: string;
 }): Middleware => {
-  return async (_params, _options, next) => {
+  return async (_params, options, next) => {
     await next();
     Object.entries(headers).forEach(([key, value]) => {
-      _options.res.headers.set(key, value);
+      options.res.headers.set(key, value);
     });
   };
 };

packages/event-handler/tests/unit/rest/middleware/compress.test.ts

@@ -107,30 +107,50 @@ describe('Compress Middleware', () => {
     expect(result.headers?.['content-encoding']).toEqual('gzip');
   });
 
-  it('skips compression for non-compressible content types', async () => {
-    // Prepare
-    const event = createTestEvent('/test', 'GET');
-    const app = new Router();
-    app.get(
-      '/test',
-      [
-        compress(),
-        createSettingHeadersMiddleware({
-          'content-length': '2000',
-          'content-type': 'image/jpeg',
-        }),
-      ],
-      async () => {
-        return { test: 'x'.repeat(2000) };
-      }
-    );
-
-    // Act
-    const result = await app.resolve(event, context);
-
-    // Assess
-    expect(result.headers?.['content-encoding']).toBeUndefined();
-  });
+  it.each([
+    'image/jpeg',
+    'image/png',
+    'image/gif',
+    'audio/mpeg',
+    'audio/mp4',
+    'audio/ogg',
+    'video/mp4',
+    'video/mpeg',
+    'video/webm',
+    'application/zip',
+    'application/gzip',
+    'application/x-gzip',
+    'application/octet-stream',
+    'application/pdf',
+    'application/msword',
+    'text/event-stream',
+  ])(
+    'skips compression for non-compressible content types',
+    async (contentType) => {
+      // Prepare
+      const event = createTestEvent('/test', 'GET');
+      const app = new Router();
+      app.get(
+        '/test',
+        [
+          compress(),
+          createSettingHeadersMiddleware({
+            'content-length': '2000',
+            'content-type': contentType,
+          }),
+        ],
+        async () => {
+          return { test: 'x'.repeat(2000) };
+        }
+      );
+
+      // Act
+      const result = await app.resolve(event, context);
+
+      // Assess
+      expect(result.headers?.['content-encoding']).toBeUndefined();
+    }
+  );
 
   it('skips compression when cache-control no-transform is set', async () => {
     // Prepare