Skip to content

Commit 49cb123

Browse files
committed
fixed test and sonar finding
1 parent 2597d5a commit 49cb123

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

packages/event-handler/src/rest/middleware/cors.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,21 +105,21 @@ export const cors = (options?: CorsOptions): Middleware => {
105105
config.maxAge.toString()
106106
);
107107
}
108-
allowedMethods.forEach((method) => {
108+
for (const method of allowedMethods) {
109109
reqCtx.res.headers.append('access-control-allow-methods', method);
110-
});
111-
allowedHeaders.forEach((header) => {
110+
}
111+
for (const header of allowedHeaders) {
112112
reqCtx.res.headers.append('access-control-allow-headers', header);
113-
});
113+
}
114114
return new Response(null, {
115115
status: HttpErrorCodes.NO_CONTENT,
116116
headers: reqCtx.res.headers,
117117
});
118118
}
119119

120-
config.exposeHeaders.forEach((header) => {
120+
for (const header of config.exposeHeaders) {
121121
reqCtx.res.headers.append('access-control-expose-headers', header);
122-
});
122+
}
123123

124124
await next();
125125
};

packages/event-handler/tests/unit/rest/middleware/cors.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ describe('CORS Middleware', () => {
197197
corsConfig.allowMethods
198198
);
199199
expect(result.multiValueHeaders?.['access-control-allow-headers']).toEqual(
200-
corsConfig.allowHeaders
200+
corsConfig.allowHeaders.map((header) => header.toLowerCase())
201201
);
202202
expect(result.headers?.['access-control-max-age']).toEqual(
203203
corsConfig.maxAge.toString()

0 commit comments

Comments
 (0)