Skip to content

Commit 6ae3368

Browse files
committed
reverted changes in the nextfunction type
1 parent 2c2ef47 commit 6ae3368

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

packages/event-handler/src/appsync-graphql/AppSyncGraphQLResolver.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ class AppSyncGraphQLResolver extends Router {
190190
* @param options - Optional resolve options for customizing resolver behavior.
191191
*/
192192
async #withErrorHandling(
193-
fn: () => Promise<unknown> | unknown,
193+
fn: () => unknown,
194194
event: AppSyncResolverEvent<Record<string, unknown>>,
195195
options?: ResolveOptions
196196
) {
@@ -377,7 +377,7 @@ class AppSyncGraphQLResolver extends Router {
377377
event: AppSyncResolverEvent<Record<string, unknown>>,
378378
context: Context,
379379
options?: ResolveOptions
380-
): Promise<unknown> | unknown {
380+
): unknown {
381381
const { fieldName, parentTypeName: typeName } = event.info;
382382

383383
const resolverHandlerOptions = this.resolverRegistry.resolve(

packages/event-handler/src/types/rest.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ interface CompiledRoute {
5454

5555
type DynamicRoute = Route & CompiledRoute;
5656

57-
type HandlerResponse = Response | JSONObject | undefined;
57+
type HandlerResponse = Response | JSONObject;
5858

5959
type RouteHandler<TReturn = HandlerResponse> = (
6060
reqCtx: RequestContext
@@ -79,16 +79,13 @@ type RestRouteOptions = {
7979
middleware?: Middleware[];
8080
};
8181

82-
type NextFunction = () =>
83-
| Promise<HandlerResponse>
84-
| HandlerResponse
85-
| Promise<void>
86-
| void;
82+
type NextFunction = () => Promise<HandlerResponse | void>; // biome-ignore lint/suspicious/noConfusingVoidType: To ensure next function is awaited
8783

8884
type Middleware = (args: {
8985
reqCtx: RequestContext;
9086
next: NextFunction;
91-
}) => NextFunction;
87+
// biome-ignore lint/suspicious/noConfusingVoidType: To ensure next function is awaited
88+
}) => Promise<HandlerResponse | void>;
9289

9390
type RouteRegistryOptions = {
9491
/**

0 commit comments

Comments
 (0)