chore: more lint issues

Author: dreamorosi

packages/event-handler/tests/unit/rest/Router/basic-routing.test.ts

@@ -153,11 +153,9 @@ describe('Class: Router - Basic Routing', () => {
       await next();
     });
     todoRouter.get('/', async () => ({ api: 'listTodos' }));
-    todoRouter.notFound(async () => {
-      return {
-        error: 'Route not found',
-      };
-    });
+    todoRouter.notFound(async () => ({
+      error: 'Route not found',
+    }));
     const consoleLogSpy = vi.spyOn(console, 'log');
     const consoleWarnSpy = vi.spyOn(console, 'warn');
 

packages/idempotency/tests/unit/idempotencyDecorator.test.ts

@@ -7,7 +7,7 @@ import { BasePersistenceLayer } from '../../src/persistence/BasePersistenceLayer
 import { PersistenceLayerTestClass } from '../helpers/idempotencyUtils.js';
 
 describe('Given a class with a function to decorate', () => {
-  it('maintains the scope of the decorated function', async () => {
+  it('maintains the scope of the decorated function', () => {
     // Prepare
     class TestClass implements LambdaInterface {
       private readonly foo = 'foo';
@@ -28,13 +28,13 @@ describe('Given a class with a function to decorate', () => {
     const handler = handlerClass.handler.bind(handlerClass);
 
     // Act
-    const result = await handler({}, context);
+    const result = handler({}, context);
 
     // Assess
     expect(result).toBe('private foo');
   });
 
-  it('passes the custom keyPrefix to the persistenceStore', async () => {
+  it('passes the custom keyPrefix to the persistenceStore', () => {
     // Prepare
     const configureSpy = vi.spyOn(BasePersistenceLayer.prototype, 'configure');
     const idempotencyConfig = new IdempotencyConfig({});
@@ -54,7 +54,7 @@ describe('Given a class with a function to decorate', () => {
     const handler = handlerClass.handler.bind(handlerClass);
 
     // Act
-    const result = await handler({}, context);
+    const result = handler({}, context);
 
     // Assess
     expect(result).toBeTruthy();

packages/parameters/src/ssm/SSMProvider.ts

@@ -671,8 +671,7 @@ class SSMProvider extends BaseProvider {
     let errors: string[] = [];
 
     // Fetch each possible batch param from cache and return if entire batch is cached
-    const { cached, toFetch } =
-      await this.getParametersByNameFromCache(parameters);
+    const { cached, toFetch } = this.getParametersByNameFromCache(parameters);
     if (Object.keys(cached).length >= Object.keys(parameters).length) {
       response = cached;
 

packages/tracer/tests/unit/Tracer.test.ts

@@ -1288,7 +1288,6 @@ describe('Class: Tracer', () => {
         @tracer.captureMethod()
         public async dummyMethod(): Promise<void> {
           await setTimeout(0); // Simulate some async operation
-          return;
         }
 
         public async handler(
@@ -1297,12 +1296,10 @@ describe('Class: Tracer', () => {
         ): Promise<void> {
           await this.dummyMethod();
           this.otherDummyMethod();
-
-          return;
         }
 
-        public otherDummyMethod(): void {
-          return;
+        public otherDummyMethod(): boolean {
+          return false;
         }
       }