style(idempotency): address SonarCloud issues

Author: dreamorosi

packages/idempotency/src/IdempotencyHandler.ts

@@ -383,20 +383,20 @@ export class IdempotencyHandler<Func extends AnyFunction> {
       if (error.name === 'IdempotencyItemAlreadyExistsError') {
         let idempotencyRecord = (error as IdempotencyItemAlreadyExistsError)
           .existingRecord;
-        if (idempotencyRecord !== undefined) {
-          // If the error includes the existing record, we can use it to validate
-          // the record being processed and cache it in memory.
-          idempotencyRecord = this.#persistenceStore.processExistingRecord(
-            idempotencyRecord,
-            this.#functionPayloadToBeHashed
-          );
+        if (idempotencyRecord === undefined) {
           // If the error doesn't include the existing record, we need to fetch
           // it from the persistence layer. In doing so, we also call the processExistingRecord
           // method to validate the record and cache it in memory.
-        } else {
           idempotencyRecord = await this.#persistenceStore.getRecord(
             this.#functionPayloadToBeHashed
           );
+        } else {
+          // If the error includes the existing record, we can use it to validate
+          // the record being processed and cache it in memory.
+          idempotencyRecord = this.#persistenceStore.processExistingRecord(
+            idempotencyRecord,
+            this.#functionPayloadToBeHashed
+          );
         }
 
         returnValue.isIdempotent = true;

packages/idempotency/src/persistence/DynamoDBPersistenceLayer.ts

@@ -88,13 +88,13 @@ class DynamoDBPersistenceLayer extends BasePersistenceLayer {
       config.staticPkValue ?? `idempotency#${this.idempotencyKeyPrefix}`;
 
     if (config.awsSdkV3Client) {
-      if (!isSdkClient(config.awsSdkV3Client)) {
+      if (isSdkClient(config.awsSdkV3Client)) {
+        this.client = config.awsSdkV3Client;
+      } else {
         console.warn(
           'awsSdkV3Client is not an AWS SDK v3 client, using default client'
         );
         this.client = new DynamoDBClient(config.clientConfig ?? {});
-      } else {
-        this.client = config.awsSdkV3Client;
       }
     } else {
       this.client = new DynamoDBClient(config.clientConfig ?? {});

packages/idempotency/tests/e2e/idempotentDecorator.test.FunctionCode.ts

@@ -35,9 +35,6 @@ class DefaultLambda implements LambdaInterface {
     logger.info(`${this.message} ${JSON.stringify(_event)}`);
     // sleep to enforce error with parallel execution
     await new Promise((resolve) => setTimeout(resolve, 1000));
-
-    // We return void to test that the utility handles it correctly
-    return;
   }
 
   @idempotent({
@@ -124,12 +121,9 @@ const handlerExpired = defaultLambda.handlerExpired.bind(defaultLambda);
 const logger = new Logger();
 
 class LambdaWithKeywordArgument implements LambdaInterface {
-  public async handler(
-    event: { id: string },
-    _context: Context
-  ): Promise<string> {
+  public handler(event: { id: string }, _context: Context) {
     config.registerLambdaContext(_context);
-    await this.process(event.id, 'bar');
+    this.process(event.id, 'bar');
 
     return 'Hello World Keyword Argument';
   }

packages/idempotency/tests/e2e/makeHandlerIdempotent.test.ts

@@ -192,15 +192,13 @@ describe('Idempotency E2E tests, middy middleware usage', () => {
      * We filter the logs to find which one was successful and which one failed, then we check
      * that they contain the expected logs.
      */
-    const successfulInvocationLogs = functionLogs.find(
-      (functionLog) =>
-        functionLog.find((log) => log.includes('Processed event')) !== undefined
+    const successfulInvocationLogs = functionLogs.find((functionLog) =>
+      functionLog.some((log) => log.includes('Processed event'))
     );
-    const failedInvocationLogs = functionLogs.find(
-      (functionLog) =>
-        functionLog.find((log) =>
-          log.includes('There is already an execution in progress')
-        ) !== undefined
+    const failedInvocationLogs = functionLogs.find((functionLog) =>
+      functionLog.some((log) =>
+        log.includes('There is already an execution in progress')
+      )
     );
     expect(successfulInvocationLogs).toHaveLength(1);
     expect(failedInvocationLogs).toHaveLength(1);

packages/idempotency/vitest.config.ts

@@ -4,7 +4,7 @@ export default defineProject({
   test: {
     environment: 'node',
     setupFiles: ['../testing/src/setupEnv.ts'],
-    hookTimeout: 1_000 * 60 * 10, // 10 minutes
-    testTimeout: 1_000 * 60 * 3, // 3 minutes
+    hookTimeout: 1000 * 60 * 10, // 10 minutes
+    testTimeout: 1000 * 60 * 3, // 3 minutes
   },
 });