Skip to content

Commit e16d54c

Browse files
committed
Updated the excemption message for using inherit
1 parent e04d472 commit e16d54c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/make-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ jobs:
9494
publish_layer:
9595
needs: publish-npm
9696
secrets:
97-
# The update_ssm workflow called from the publish_layer workflow needs the secrets for all the regions. This will trigger a SonarQube warning.
97+
# We use "inherit" because need to propagate the secrets to the reusable workflow, secrets are already scoped by using GitHub's deployment environments to mitigate the risk of secret exposure.
9898
inherit
9999
permissions:
100100
id-token: write

.github/workflows/publish_layer.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
package_version: ${{ inputs.latest_published_version }}
9999
layer-version: ${{ needs.deploy-prod.outputs.layer-version }}
100100
secrets:
101-
# The update_ssm workflow needs the secrets for all the regions. This will trigger a SonarQube warning.
101+
# We use "inherit" because need to propagate the secrets to the reusable workflow, secrets are already scoped by using GitHub's deployment environments to mitigate the risk of secret exposure.
102102
inherit
103103

104104
update_layer_arn_docs:

0 commit comments

Comments
 (0)