diff --git a/packages/parameters/src/appconfig/AppConfigProvider.ts b/packages/parameters/src/appconfig/AppConfigProvider.ts index 61811575d0..1975968c99 100644 --- a/packages/parameters/src/appconfig/AppConfigProvider.ts +++ b/packages/parameters/src/appconfig/AppConfigProvider.ts @@ -189,8 +189,8 @@ class AppConfigProvider extends BaseProvider { { value: string; expiration: number } >(); protected valueStore = new Map(); - private application?: string; - private environment: string; + private readonly application?: string; + private readonly environment: string; /** * It initializes the AppConfigProvider class. diff --git a/packages/parameters/src/base/BaseProvider.ts b/packages/parameters/src/base/BaseProvider.ts index dee5f8df5a..c8e9fab2e4 100644 --- a/packages/parameters/src/base/BaseProvider.ts +++ b/packages/parameters/src/base/BaseProvider.ts @@ -92,7 +92,7 @@ abstract class BaseProvider implements BaseProviderInterface { public async get( name: string, options?: GetOptionsInterface - ): Promise { + ): Promise { const configs = new GetOptions(options); const key = [name, configs.transform].toString(); diff --git a/packages/parameters/src/dynamodb/DynamoDBProvider.ts b/packages/parameters/src/dynamodb/DynamoDBProvider.ts index cbdea3580e..2678d31113 100644 --- a/packages/parameters/src/dynamodb/DynamoDBProvider.ts +++ b/packages/parameters/src/dynamodb/DynamoDBProvider.ts @@ -1,13 +1,11 @@ import type { JSONValue } from '@aws-lambda-powertools/commons/types'; -import type { - GetItemCommandInput, - QueryCommandInput, -} from '@aws-sdk/client-dynamodb'; import { DynamoDBClient, type DynamoDBPaginationConfiguration, GetItemCommand, + type GetItemCommandInput, paginateQuery, + type QueryCommandInput, } from '@aws-sdk/client-dynamodb'; import { marshall, unmarshall } from '@aws-sdk/util-dynamodb'; import { BaseProvider } from '../base/BaseProvider.js'; diff --git a/packages/parameters/src/ssm/SSMProvider.ts b/packages/parameters/src/ssm/SSMProvider.ts index 6e59543b59..d905ab2681 100644 --- a/packages/parameters/src/ssm/SSMProvider.ts +++ b/packages/parameters/src/ssm/SSMProvider.ts @@ -821,7 +821,7 @@ class SSMProvider extends BaseProvider { * @param {boolean} throwOnError - Whether to throw an error if any of the parameters' retrieval throws an error or handle them gracefully */ protected static handleAnyInvalidGetParameterErrors( - result: GetParametersCommandOutput, + result: Partial, throwOnError: boolean ): string[] { const errors: string[] = []; @@ -920,7 +920,7 @@ class SSMProvider extends BaseProvider { * @param {boolean} throwOnError - Whether to throw an error if any of the parameters' retrieval throws an error or handle them gracefully */ protected transformAndCacheGetParametersResponse( - response: GetParametersCommandOutput, + response: Partial, parameters: Record, throwOnError: boolean ): Record { diff --git a/packages/parameters/tests/helpers/tinyLogger.ts b/packages/parameters/tests/helpers/tinyLogger.ts index c49ec87ed6..0a078c4197 100644 --- a/packages/parameters/tests/helpers/tinyLogger.ts +++ b/packages/parameters/tests/helpers/tinyLogger.ts @@ -13,7 +13,7 @@ import { Console } from 'node:console'; * the function code is working as expected. */ export class TinyLogger { - private console = new Console({ + private readonly console: Console = new Console({ stdout: process.stdout, stderr: process.stderr, }); diff --git a/packages/parameters/tests/unit/BaseProvider.test.ts b/packages/parameters/tests/unit/BaseProvider.test.ts index b2788a2dc2..c27575235a 100644 --- a/packages/parameters/tests/unit/BaseProvider.test.ts +++ b/packages/parameters/tests/unit/BaseProvider.test.ts @@ -24,7 +24,7 @@ class TestProvider extends BaseProvider { public constructor() { super({ awsSdkV3ClientPrototype: class { - #name = 'TestProvider'; + readonly #name: string = 'TestProvider'; public hello(): string { return this.#name; @@ -412,7 +412,7 @@ describe('Class: BaseProvider', () => { // Act & Assess await expect( provider.getMultiple('my-path', { - // @ts-ignore - we want to test an unexpected runtime error + // @ts-expect-error - we want to test an unexpected runtime error transform: 1, throwOnTransformError: true, }) diff --git a/packages/parameters/tests/unit/SSMProvider.test.ts b/packages/parameters/tests/unit/SSMProvider.test.ts index 28471110c1..0b28f6863a 100644 --- a/packages/parameters/tests/unit/SSMProvider.test.ts +++ b/packages/parameters/tests/unit/SSMProvider.test.ts @@ -1012,7 +1012,7 @@ describe('Class: SSMProvider', () => { throwOnError: boolean ): string[] { return SSMProvider.handleAnyInvalidGetParameterErrors( - result as GetParametersCommandOutput, + result, throwOnError ); } @@ -1232,7 +1232,7 @@ describe('Class: SSMProvider', () => { throwOnError: boolean ): Record { return super.transformAndCacheGetParametersResponse( - response as GetParametersCommandOutput, + response, parameters, throwOnError );