From cdb56066e9f12de4a0e08e2bc9e42a89934500f9 Mon Sep 17 00:00:00 2001 From: Swopnil Dangol Date: Wed, 3 Sep 2025 13:38:01 +0100 Subject: [PATCH 1/3] Changed the formatter test to match the error object instead of deep equality --- packages/logger/tests/unit/formatters.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/logger/tests/unit/formatters.test.ts b/packages/logger/tests/unit/formatters.test.ts index f5ed37f419..26f716c91a 100644 --- a/packages/logger/tests/unit/formatters.test.ts +++ b/packages/logger/tests/unit/formatters.test.ts @@ -450,7 +450,7 @@ describe('Formatters', () => { const formattedError = formatter.formatError(error); // Assess - expect(formattedError).toEqual({ + expect(formattedError).toMatchObject({ stack: expect.arrayContaining([ expect.stringMatching(fileNameRegexpWithLine), ]), From 1a10ef5262cfcaa1c80164b031e85086e28c2d52 Mon Sep 17 00:00:00 2001 From: Swopnil Dangol Date: Wed, 3 Sep 2025 13:49:59 +0100 Subject: [PATCH 2/3] Added the missing property instead of relaxing the checking --- packages/logger/tests/unit/formatters.test.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/logger/tests/unit/formatters.test.ts b/packages/logger/tests/unit/formatters.test.ts index 26f716c91a..b95eee561a 100644 --- a/packages/logger/tests/unit/formatters.test.ts +++ b/packages/logger/tests/unit/formatters.test.ts @@ -371,6 +371,7 @@ describe('Formatters', () => { operator: 'strictEqual', code: 'ERR_ASSERTION', generatedMessage: true, + diff: 'simple', }, }, { @@ -450,7 +451,7 @@ describe('Formatters', () => { const formattedError = formatter.formatError(error); // Assess - expect(formattedError).toMatchObject({ + expect(formattedError).toEqual({ stack: expect.arrayContaining([ expect.stringMatching(fileNameRegexpWithLine), ]), From 86f14b4b55e930de7526e9e69734add83405b2f6 Mon Sep 17 00:00:00 2001 From: Swopnil Dangol Date: Wed, 3 Sep 2025 14:02:03 +0100 Subject: [PATCH 3/3] Added a conditional check to add the diff property only with node versions greater than 22.19.0 --- packages/logger/tests/unit/formatters.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/logger/tests/unit/formatters.test.ts b/packages/logger/tests/unit/formatters.test.ts index b95eee561a..0f335d0d5b 100644 --- a/packages/logger/tests/unit/formatters.test.ts +++ b/packages/logger/tests/unit/formatters.test.ts @@ -371,7 +371,7 @@ describe('Formatters', () => { operator: 'strictEqual', code: 'ERR_ASSERTION', generatedMessage: true, - diff: 'simple', + diff: process.versions.node >= '22.19.0' ? 'simple' : undefined, }, }, {