fix(batch): declare the @aws-lambda-powertools/commons dependency #4484
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
batch
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
pull-request-size
bot
added
size/S
pull-request-size
bot
added
size/XS
sdangol
previously approved these changes
Sep 15, 2025
pull-request-size
bot
added
size/L
pull-request-size
bot
added
size/S
pull-request-size
bot
added
size/XS
dreamorosi
approved these changes
Sep 15, 2025
|
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
|
@aws-powertools/lambda-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
@aws-lambda-powertools/commonsdependency was not declared in thebatchpackage.It seems that this regression has been introduced with #4465.
See https://github.com/aws-powertools/powertools-lambda-typescript/pull/4465/files#diff-179ff02baca1caba368814f8214b5dbdf33c3e9bf7cebe51014d0dfb54c59dadR1
Changes
@aws-lambda-powertools/commonsas dependency forbatchcommonspackage instead of../../commons/lib/esm/types/GenericLogger.jsimports.BatchProcessorimport in types.fixes #4485
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.