From c90da4e6f80aa90edc234dcafb9fe4c81d0a62e8 Mon Sep 17 00:00:00 2001 From: Andrea Amorosi Date: Wed, 24 Sep 2025 16:47:28 +0200 Subject: [PATCH 1/2] style(testing): apply stricter linting --- packages/testing/src/TestStack.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/testing/src/TestStack.ts b/packages/testing/src/TestStack.ts index 59bb975385..c42c30c7cd 100644 --- a/packages/testing/src/TestStack.ts +++ b/packages/testing/src/TestStack.ts @@ -80,6 +80,8 @@ class TestStack { * Otherwise, we log messages that are either warnings or errors as well as periodic * updates on the stack creation and destruction process. * + * biome-ignore lint/suspicious/useAwait: The CDK interface requires this to be async + * * @param msg - Message to log sent by the CDK CLI */ async notify(msg) { @@ -115,6 +117,7 @@ class TestStack { testConsole.log(msg); } }, + // biome-ignore lint/suspicious/useAwait: The CDK interface requires this to be async async requestResponse(msg) { if ( process.env.RUNNER_DEBUG === '1' || From f656481a213ac03610883a5b70545840ddab8864 Mon Sep 17 00:00:00 2001 From: Andrea Amorosi Date: Wed, 24 Sep 2025 16:53:03 +0200 Subject: [PATCH 2/2] style(testing): address SonarCloud issues --- packages/testing/src/setupEnv.ts | 2 +- packages/testing/src/xray-traces-utils.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/testing/src/setupEnv.ts b/packages/testing/src/setupEnv.ts index 7363a80828..4960f75795 100644 --- a/packages/testing/src/setupEnv.ts +++ b/packages/testing/src/setupEnv.ts @@ -228,7 +228,7 @@ expect.addEqualityTesters([ // or this.equals(a.message, b.message) return this.equals(a.issues, b.issues); } - return aOk !== bOk ? false : undefined; + return aOk === bOk ? undefined : false; }, ]); diff --git a/packages/testing/src/xray-traces-utils.ts b/packages/testing/src/xray-traces-utils.ts index df1071e12d..b6115b3b88 100644 --- a/packages/testing/src/xray-traces-utils.ts +++ b/packages/testing/src/xray-traces-utils.ts @@ -16,7 +16,7 @@ import type { const retryOptions = { retries: 20, - minTimeout: 5_000, + minTimeout: 5000, maxTimeout: 10_000, factor: 1.25, };