Bug fix: fail the action when catching exception from cli command (#13)

* Bug fix: fail the action when catching exception from cli command

- We need to fail the action whenever there is an exception, we already did that in multiple places except in fetchRosinstallDependencies and getSampleAppVersion

Author: wangvnn

robomaker-sample-app-ci/dist/index.js

@@ -724,24 +724,27 @@ function getSampleAppVersion() {
             ], getWorkingDirExecOptions(grepAfter));
             version = grepAfter.stdout.trim();
         }
-        catch (err) {
-            console.error(err);
+        catch (error) {
+            core.setFailed(error.message);
         }
         return Promise.resolve(version);
     });
 }
-// If .rosinstall exists, run 'rosws update' and return a list of names of the packages that were added.
+// If .rosinstall exists, run 'vcs import' and return a list of names of the packages that were added in both workspaces.
 function fetchRosinstallDependencies() {
     return __awaiter(this, void 0, void 0, function* () {
         let colconListAfter = { stdout: '', stderr: '' };
         let packages = [];
         // Download dependencies not in apt if .rosinstall exists
         try {
+            // When generate-sources: true, the expected behavior is to include sources from both workspaces including their dependencies. 
+            // In order to make generate-sources work as expected, dependencies are fetched in both the workspaces here.
             for (let workspace of ["robot_ws", "simulation_ws"]) {
                 if (fs.existsSync(path.join(workspace, '.rosinstall'))) {
-                  yield exec.exec("vcs", ["import", "--input", ".rosinstall"], {cwd: workspace});
+                    yield exec.exec("vcs", ["import", "--input", ".rosinstall"], { cwd: workspace });
                 }
             }
+            // this is outside the loop as we don't want to build both the dependency packages
             if (fs.existsSync(path.join(WORKSPACE_DIRECTORY, '.rosinstall'))) {
                 yield exec.exec("colcon", ["list", "--names-only"], getWorkingDirExecOptions(colconListAfter));
                 const packagesAfter = colconListAfter.stdout.split("\n");
@@ -750,13 +753,12 @@ function fetchRosinstallDependencies() {
                 });
             }
         }
-        catch (err) {
-            console.error(err);
+        catch (error) {
+            core.setFailed(error.message);
         }
         return Promise.resolve(packages);
     });
 }
-
 function setup() {
     return __awaiter(this, void 0, void 0, function* () {
         try {

robomaker-sample-app-ci/src/aws-robomaker-sample-application-ci.ts

@@ -66,8 +66,8 @@ async function getSampleAppVersion() : Promise<string> {
          "find ../robot_ws -name package.xml -exec grep -Po '(?<=<version>)[^\\s<>]*(?=</version>)' {} +"],
       getWorkingDirExecOptions(grepAfter));
     version = grepAfter.stdout.trim();
-  } catch(err) {
-    console.error(err);
+  } catch(error) {
+    core.setFailed(error.message);
   }
   return Promise.resolve(version);
 }
@@ -93,8 +93,8 @@ async function fetchRosinstallDependencies(): Promise<string[]> {
         packages.push(packageName.trim());
       });
     }
-  } catch(err) {
-    console.error(err);
+  } catch(error) {
+    core.setFailed(error.message);
   }
   return Promise.resolve(packages);
 }