Skip to content

Commit 846e5a6

Browse files
tungbqMarinaburkhardt
authored andcommitted
🐛 improving some typo in README.md files
1 parent 429cef4 commit 846e5a6

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ The task definition template (Infrastructure/Templates/taskdef.json) that enable
6565

6666
Feel free to change it, by adding for example a set of "sed" commands in CodeBuild (following the ones already provided as example) to replace the values dynamically.
6767

68-
Feel fre to create a subscriptor for the SNS topic created by this code, in order to get informed of the status of each finished CodeDeploy deployment.
68+
Feel free to create a subscriptor for the SNS topic created by this code, in order to get informed of the status of each finished CodeDeploy deployment.
6969

7070
## CI/CD Architecture
7171

@@ -107,7 +107,7 @@ cd Infrastructure/
107107
terraform init
108108
```
109109
**4.** Run the terraform plan command, feel free to use a tfvars file to specify the variables.
110-
You need to set at least the followign variables:
110+
You need to set at least the following variables:
111111
+ **aws_profile** = according to the profiles name in ~/.aws/credentials
112112
+ **aws_region** = the AWS region in which you want to create the resources
113113
+ **environment_name** = a unique name used for concatenation to give place to the resources names
@@ -131,19 +131,19 @@ terraform plan -var aws_profile="development" -var aws_region="eu-central-1" -va
131131
terraform apply -var aws_profile="your-profile" -var aws_region="your-region" -var environment_name="your-env" -var github_token="your-personal-token" -var repository_name="your-github-repository" -var repository_owner="the-github-repository-owner"
132132
```
133133

134-
**6.** Once Terraform finishes the deployment open the AWS Management Console and go to the AWS CodePipeline service. You will see that the pipeline, which was created by this Terraform code, is in progress. Add some files and Dynamodb items as mentioned [here](#client-considerations-due-to-demo-proposals). Once the pipeline finished successfully and the before assets were added, go back to the console where Terraform was executed, copy the *application_url* value from the output and open it in a browser.
134+
**6.** Once Terraform finishes the deployment, open the AWS Management Console and go to the AWS CodePipeline service. You will see that the pipeline, which was created by this Terraform code, is in progress. Add some files and DynamoDB items as mentioned [here](#client-considerations-due-to-demo-proposals). Once the pipeline finished successfully and the before assets were added, go back to the console where Terraform was executed, copy the *application_url* value from the output and open it in a browser.
135135

136-
**7.** In order to access the also implemented Swagger endpoint copy the *swagger_endpoint* value from the Terraform output and open it in a browser.
136+
**7.** In order to access the also implemented Swagger endpoint, copy the *swagger_endpoint* value from the Terraform output and open it in a browser.
137137

138138
## Autoscaling test
139139

140140
To test how your application will perform under a peak of traffic, a stress test configuration file is provided.
141141

142142
For this stress test [Artillery](https://artillery.io/) is being used. Please be sure to install it following [these](https://artillery.io/docs/guides/getting-started/installing-artillery.html) steps.
143143

144-
Once installed please change the ALB DNS to the desired layer to test (front-/backend) in the **target** attribute, which you can copy from the generated Terraform output, or you can also search it in the AWS Management Console.
144+
Once installed, please change the ALB DNS to the desired layer to test (front/backend) in the **target** attribute, which you can copy from the generated Terraform output, or you can also search it in the AWS Management Console.
145145

146-
To execute it run the following commands:
146+
To execute it, run the following commands:
147147

148148
*Frontend layer:*
149149
```bash
@@ -155,7 +155,7 @@ artillery run Code/client/src/tests/stresstests/stress_client.yml
155155
artillery run Code/server/src/tests/stresstests/stress_server.yml
156156
```
157157

158-
To learn more about Amazon ECS Autoscaling please take a look to [this](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/service-auto-scaling.html) documentation.
158+
To learn more about Amazon ECS Autoscaling, please take a look to [this](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/service-auto-scaling.html) documentation.
159159
## Application Code
160160

161161
### Client app

0 commit comments

Comments
 (0)