Skip to content

Commit 0ba199d

Browse files
authored
kvs_stream: pxDataFrame used before input validation (#91)
1 parent 02ba977 commit 0ba199d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/source/stream/stream.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -460,12 +460,6 @@ int Kvs_dataFrameAddTags(DataFrameHandle xDataFrameHandle, MkvTag_t* tagsList, s
460460

461461
static bool firstClusterSeen = false;
462462

463-
if (pxDataFrame->xDataFrameIn.xClusterType != MKV_CLUSTER)
464-
{
465-
LogInfo("Not a cluster");
466-
return KVS_ERRNO_NONE;
467-
}
468-
469463
// Input validation
470464
if (pxDataFrame == NULL || ppMkvHeader == NULL ||
471465
puMkvHeaderLen == NULL || ppData == NULL || puDataLen == NULL)
@@ -474,6 +468,12 @@ int Kvs_dataFrameAddTags(DataFrameHandle xDataFrameHandle, MkvTag_t* tagsList, s
474468
return KVS_ERROR_INVALID_ARGUMENT;
475469
}
476470

471+
if (pxDataFrame->xDataFrameIn.xClusterType != MKV_CLUSTER)
472+
{
473+
LogInfo("Not a cluster");
474+
return KVS_ERRNO_NONE;
475+
}
476+
477477
size_t effectiveTagsLen = tagsListLen + (endOfStream ? 1 : 0);
478478
if (effectiveTagsLen >= MAX_TAG_AMOUNT) {
479479
LogError("Trying to add too many tags - Adding: %zu tags, Max: %d", effectiveTagsLen, MAX_TAG_AMOUNT);

0 commit comments

Comments
 (0)