Skip to content

Commit f89b00f

Browse files
Merge pull request #230 from djiten75/main
Fix pytest 9.x compatibility and nova-act viewport resolution
2 parents 8e92935 + 612993d commit f89b00f

File tree

3 files changed

+42
-2
lines changed

3 files changed

+42
-2
lines changed

nova-act/usecases/qa-testing/tests/README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,13 @@ The project uses several pytest plugins to enhance testing capabilities:
255255

256256
These plugins are automatically installed with the project dependencies. No additional configuration is required.
257257

258+
## Expected Test Failures
259+
260+
The following tests are expected to fail:
261+
262+
1. **QA-03-Product Display and Images Test**
263+
2. **QA-05-Product Filter Functionality Test**
264+
258265
## Additional Resources
259266

260267
- [Amazon Nova Act](https://novs.amazon.com/act)
Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
"""
2+
Root-level conftest.py for pytest configuration.
3+
4+
This file registers command-line options early in the pytest initialization process,
5+
ensuring compatibility with pytest 9.x which validates addopts before loading plugins.
6+
"""
7+
8+
import pytest
9+
10+
11+
def pytest_addoption(parser: pytest.Parser) -> None:
12+
"""
13+
Register command-line options early for pytest 9.x compatibility.
14+
15+
This hook runs before pytest validates the addopts from pyproject.toml,
16+
ensuring that the --add-nova-act-report option is recognized.
17+
18+
Note: The actual plugin implementation is in pytest-html-nova-act package.
19+
This is just an early registration to satisfy pytest 9.x config validation.
20+
We check if the option already exists to avoid conflicts.
21+
"""
22+
group = parser.getgroup("terminal reporting")
23+
24+
# Only add the option if it hasn't been added yet
25+
# This prevents conflicts if the plugin has already registered it
26+
try:
27+
group.addoption(
28+
"--add-nova-act-report",
29+
action="store_true",
30+
default=False,
31+
help="Enable adding expandable links to the pytest-html report.",
32+
)
33+
except ValueError:
34+
# Option already exists, which is fine
35+
pass

nova-act/usecases/qa-testing/tests/src/utils/nova_act.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,6 @@ def start_nova_act(
148148
logs_directory=logs_dir,
149149
user_data_dir=user_data_dir,
150150
clone_user_data_dir=False,
151-
screen_width=1920,
152-
screen_height=1080,
153151
)
154152

155153
nova.start()

0 commit comments

Comments
 (0)