Skip to content

Commit 8723558

Browse files
author
Sebastian Schürmann
committed
refactor: naming of definitions for the quicksight table
1 parent e3b4353 commit 8723558

File tree

3 files changed

+22
-16
lines changed

3 files changed

+22
-16
lines changed

typescript/quicksight/lib/logical-columns.ts renamed to typescript/quicksight/lib/data-transforms.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
export const logicalColumns = [
1+
import { CfnDataSet } from "aws-cdk-lib/aws-quicksight";
2+
/**
3+
* @see https://docs.aws.amazon.com/quicksight/latest/APIReference/API_TransformOperation.html
4+
*/
5+
export const dataTransforms: CfnDataSet.TransformOperationProperty[] = [
26
{
37
"castColumnTypeOperation": {
48
"columnName": "1960",

typescript/quicksight/lib/physical-columns.ts renamed to typescript/quicksight/lib/input-columns.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
export const physicalColumns = [
1+
2+
export const inputColumns = [
23
{ "name": "Country Name", "type": "STRING"},
34
{ "name": "Country Code", "type": "STRING"},
45
{ "name": "1960", "type": "STRING"},

typescript/quicksight/lib/quicksight-example-stack.ts

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import {BucketDeployment, Source} from 'aws-cdk-lib/aws-s3-deployment';
44
import {CfnDataSet, CfnDataSource, CfnTemplate} from 'aws-cdk-lib/aws-quicksight';
55
import {CfnManagedPolicy} from 'aws-cdk-lib/aws-iam';
66
import { Stack, StackProps } from 'aws-cdk-lib';
7-
import {logicalColumns} from './logical-columns';
8-
import {physicalColumns} from './physical-columns';
7+
import {dataTransforms} from './data-transforms';
8+
import {inputColumns} from './input-columns';
99

1010
export class QuicksightExampleStack extends Stack {
1111
/**
@@ -156,20 +156,10 @@ export class QuicksightExampleStack extends Stack {
156156
quicksightS3DataSource.node.addDependency(managedPolicy);
157157
quicksightS3DataSource.node.addDependency(deployment);
158158

159-
const transformOperations: CfnDataSet.TransformOperationProperty[] = logicalColumns;
160-
161-
const logicalTableProperties = {
162-
alias: 's3-extract-data-cast',
163-
source: {
164-
physicalTableId: QuicksightExampleStack.QUICKSIGHT_DATASOURCE_NAME
165-
},
166-
dataTransforms: transformOperations
167-
}
168-
169-
const physicalTableProperties = {
159+
const physicalTableProperties: CfnDataSet.PhysicalTableProperty = {
170160
s3Source: {
171161
dataSourceArn: quicksightS3DataSource.attrArn,
172-
inputColumns: physicalColumns,
162+
inputColumns,
173163
uploadSettings: {
174164
format: 'CSV',
175165
delimiter: ',',
@@ -178,6 +168,17 @@ export class QuicksightExampleStack extends Stack {
178168
}
179169
}
180170
}
171+
/**
172+
* @see https://docs.aws.amazon.com/quicksight/latest/APIReference/API_LogicalTable.html
173+
*/
174+
const logicalTableProperties: CfnDataSet.LogicalTableProperty = {
175+
alias: 's3-extract-data-cast',
176+
source: {
177+
physicalTableId: QuicksightExampleStack.QUICKSIGHT_DATASOURCE_NAME
178+
},
179+
dataTransforms
180+
}
181+
181182
const datasetName = 'quicksightExampleDataset';
182183
new CfnDataSet(
183184
this,

0 commit comments

Comments
 (0)