Skip to content

Commit c02c300

Browse files
author
Michael Kaiser
committed
Update snapshot for inspector2
1 parent 83d2755 commit c02c300

File tree

5 files changed

+169
-247
lines changed

5 files changed

+169
-247
lines changed

‎.github/workflows/build-pull-request.yml‎

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
run: |
4646
# Create a temporary directory for build logs
4747
mkdir -p /tmp/build_logs
48-
npm install -g eslint
48+
npm install -g eslint > /dev/null
4949
5050
# Function to build a single file
5151
build_file() {
@@ -67,9 +67,25 @@ jobs:
6767
# Run the build command and capture output to both the log file and stdout
6868
../scripts/build-${language}.sh "$file" 2>&1 | tee "$log_file"
6969
local exit_code=${PIPESTATUS[0]}
70-
70+
7171
if [ $exit_code -eq 0 ]; then
7272
echo "✅ Build succeeded for $file"
73+
74+
# Clean up node_modules and cdk.out for this project immediately after successful build
75+
echo "Cleaning up build artifacts for $(dirname "$file")"
76+
local project_dir=$(dirname "$file")
77+
78+
# Remove node_modules directory if it exists
79+
if [ -d "$project_dir/node_modules" ]; then
80+
echo "Removing $project_dir/node_modules"
81+
rm -rf "$project_dir/node_modules"
82+
fi
83+
84+
# Remove cdk.out directory if it exists
85+
if [ -d "$project_dir/cdk.out" ]; then
86+
echo "Removing $project_dir/cdk.out"
87+
rm -rf "$project_dir/cdk.out"
88+
fi
7389
else
7490
echo "❌ Build failed for $file with exit code $exit_code"
7591
echo "::error::Build failed for $file with exit code $exit_code"
@@ -130,21 +146,6 @@ jobs:
130146
# Check the exit status of parallel
131147
parallel_exit=$?
132148
133-
# If parallel succeeded, clean up node_modules and cdk.out to save space
134-
if [ $parallel_exit -eq 0 ]; then
135-
echo "::group::Cleaning up build artifacts"
136-
# Find all node_modules directories within the language directory and remove them
137-
echo "Removing node_modules directories..."
138-
find ./ -name "node_modules" -type d -prune -exec rm -rf {} \; 2>/dev/null || true
139-
140-
# Find all cdk.out directories within the language directory and remove them
141-
echo "Removing cdk.out directories..."
142-
find ./ -name "cdk.out" -type d -prune -exec rm -rf {} \; 2>/dev/null || true
143-
144-
echo "Cleanup completed"
145-
echo "::endgroup::"
146-
fi
147-
148149
# If parallel failed, make sure the workflow fails too
149150
if [ $parallel_exit -ne 0 ]; then
150151
echo "::error::One or more builds failed. See build output above for details."

‎typescript/inspector2/test/__snapshots__/inspector2-enable-delegated-admin-account-resource.test.ts.snap‎

Lines changed: 35 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -3,126 +3,105 @@
33
exports[`Inspector2EnableDelegatedAdminAccountResource creates required resources 1`] = `
44
{
55
"Mappings": {
6-
"LatestNodeRuntimeMap": {
6+
"DefaultCrNodeVersionMap": {
77
"af-south-1": {
8-
"value": "nodejs20.x",
8+
"value": "nodejs16.x",
99
},
1010
"ap-east-1": {
11-
"value": "nodejs20.x",
11+
"value": "nodejs16.x",
1212
},
1313
"ap-northeast-1": {
14-
"value": "nodejs20.x",
14+
"value": "nodejs16.x",
1515
},
1616
"ap-northeast-2": {
17-
"value": "nodejs20.x",
17+
"value": "nodejs16.x",
1818
},
1919
"ap-northeast-3": {
20-
"value": "nodejs20.x",
20+
"value": "nodejs16.x",
2121
},
2222
"ap-south-1": {
23-
"value": "nodejs20.x",
23+
"value": "nodejs16.x",
2424
},
2525
"ap-south-2": {
26-
"value": "nodejs20.x",
26+
"value": "nodejs16.x",
2727
},
2828
"ap-southeast-1": {
29-
"value": "nodejs20.x",
29+
"value": "nodejs16.x",
3030
},
3131
"ap-southeast-2": {
32-
"value": "nodejs20.x",
32+
"value": "nodejs16.x",
3333
},
3434
"ap-southeast-3": {
35-
"value": "nodejs20.x",
36-
},
37-
"ap-southeast-4": {
38-
"value": "nodejs20.x",
39-
},
40-
"ap-southeast-5": {
41-
"value": "nodejs20.x",
42-
},
43-
"ap-southeast-7": {
44-
"value": "nodejs20.x",
35+
"value": "nodejs16.x",
4536
},
4637
"ca-central-1": {
47-
"value": "nodejs20.x",
48-
},
49-
"ca-west-1": {
50-
"value": "nodejs20.x",
38+
"value": "nodejs16.x",
5139
},
5240
"cn-north-1": {
53-
"value": "nodejs20.x",
41+
"value": "nodejs16.x",
5442
},
5543
"cn-northwest-1": {
56-
"value": "nodejs20.x",
44+
"value": "nodejs16.x",
5745
},
5846
"eu-central-1": {
59-
"value": "nodejs20.x",
47+
"value": "nodejs16.x",
6048
},
6149
"eu-central-2": {
62-
"value": "nodejs20.x",
63-
},
64-
"eu-isoe-west-1": {
65-
"value": "nodejs18.x",
50+
"value": "nodejs16.x",
6651
},
6752
"eu-north-1": {
68-
"value": "nodejs20.x",
53+
"value": "nodejs16.x",
6954
},
7055
"eu-south-1": {
71-
"value": "nodejs20.x",
56+
"value": "nodejs16.x",
7257
},
7358
"eu-south-2": {
74-
"value": "nodejs20.x",
59+
"value": "nodejs16.x",
7560
},
7661
"eu-west-1": {
77-
"value": "nodejs20.x",
62+
"value": "nodejs16.x",
7863
},
7964
"eu-west-2": {
80-
"value": "nodejs20.x",
65+
"value": "nodejs16.x",
8166
},
8267
"eu-west-3": {
83-
"value": "nodejs20.x",
84-
},
85-
"il-central-1": {
86-
"value": "nodejs20.x",
68+
"value": "nodejs16.x",
8769
},
8870
"me-central-1": {
89-
"value": "nodejs20.x",
71+
"value": "nodejs16.x",
9072
},
9173
"me-south-1": {
92-
"value": "nodejs20.x",
93-
},
94-
"mx-central-1": {
95-
"value": "nodejs20.x",
74+
"value": "nodejs16.x",
9675
},
9776
"sa-east-1": {
98-
"value": "nodejs20.x",
77+
"value": "nodejs16.x",
9978
},
10079
"us-east-1": {
101-
"value": "nodejs20.x",
80+
"value": "nodejs16.x",
10281
},
10382
"us-east-2": {
104-
"value": "nodejs20.x",
83+
"value": "nodejs16.x",
10584
},
10685
"us-gov-east-1": {
107-
"value": "nodejs20.x",
86+
"value": "nodejs16.x",
10887
},
10988
"us-gov-west-1": {
110-
"value": "nodejs20.x",
89+
"value": "nodejs16.x",
11190
},
11291
"us-iso-east-1": {
113-
"value": "nodejs18.x",
92+
"value": "nodejs14.x",
11493
},
11594
"us-iso-west-1": {
116-
"value": "nodejs18.x",
95+
"value": "nodejs14.x",
11796
},
11897
"us-isob-east-1": {
119-
"value": "nodejs18.x",
98+
"value": "nodejs14.x",
12099
},
121100
"us-west-1": {
122-
"value": "nodejs20.x",
101+
"value": "nodejs16.x",
123102
},
124103
"us-west-2": {
125-
"value": "nodejs20.x",
104+
"value": "nodejs16.x",
126105
},
127106
},
128107
},
@@ -146,7 +125,6 @@ exports[`Inspector2EnableDelegatedAdminAccountResource creates required resource
146125
"S3Key": "NORMALIZED_ASSET_HASH.zip",
147126
},
148127
"Handler": "index.handler",
149-
"MemorySize": 512,
150128
"Role": {
151129
"Fn::GetAtt": [
152130
"Inspector2EnableDelegatedAdminAccountResourceInspector2EnableResourceInspectorRole00253606",
@@ -155,7 +133,7 @@ exports[`Inspector2EnableDelegatedAdminAccountResource creates required resource
155133
},
156134
"Runtime": {
157135
"Fn::FindInMap": [
158-
"LatestNodeRuntimeMap",
136+
"DefaultCrNodeVersionMap",
159137
{
160138
"Ref": "AWS::Region",
161139
},

0 commit comments

Comments
 (0)