Skip to content
This repository was archived by the owner on Aug 9, 2023. It is now read-only.

Commit 528bbf8

Browse files
authored
Merge pull request #56 from wleepang/update/optional-bucket-name
fix bucket name propagation to nested templates
2 parents b888082 + 18ae2c9 commit 528bbf8

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

src/templates/cromwell/cromwell-aio.template.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,8 @@ Resources:
224224
KeyName: !Ref 'KeyPairName'
225225
SSHLocation: !Ref 'SSHLocation'
226226
HTTPLocation: !Ref 'HTTPLocation'
227-
S3BucketName: !Ref 'S3BucketName'
227+
# possibly autogenerated s3 bucket name
228+
S3BucketName: !GetAtt 'GenomicsWorkflowStack.Outputs.GenomicsEnvS3Bucket'
228229
BatchQueue: !GetAtt 'GenomicsWorkflowStack.Outputs.GenomicsEnvDefaultJobQueueArn'
229230
Tags: !FindInMap ["TagMap", "default", "tags"]
230231

src/templates/nextflow/nextflow-aio.template.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,11 +209,13 @@ Resources:
209209
Properties:
210210
TemplateURL: !Sub ${TemplateRootUrl}/nextflow/nextflow-resources.template.yaml
211211
Parameters:
212-
S3DataBucketName: !Ref S3DataBucketName
212+
# possibly autogenerated bucket name
213+
S3DataBucketName: !GetAtt GenomicsWorkflowStack.Outputs.GenomicsEnvS3Bucket
213214
S3NextflowBucketName:
214215
Fn::If:
215216
- UseOneBucket
216-
- !Ref S3DataBucketName
217+
# possibly autogenerated bucket name
218+
- !GetAtt GenomicsWorkflowStack.Outputs.GenomicsEnvS3Bucket
217219
- !Ref S3NextflowBucketName
218220
ExistingBucket:
219221
Fn::If:

src/templates/step-functions/sfn-aio.template.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,8 @@ Resources:
164164
Properties:
165165
TemplateURL: !Sub ${TemplateRootUrl}/step-functions/sfn-${StateMachine}.template.yaml
166166
Parameters:
167-
S3BucketName: !Ref 'S3BucketName'
167+
# possibly autogenerated s3 bucket name
168+
S3BucketName: !GetAtt 'GenomicsWorkflowStack.Outputs.GenomicsEnvS3Bucket'
168169
BatchJobQueue: !GetAtt 'GenomicsWorkflowStack.Outputs.GenomicsEnvDefaultJobQueueArn'
169170
Tags: !FindInMap ["TagMap", "default", "tags"]
170171

0 commit comments

Comments
 (0)